Skip to content

munge submodule names

Brandon Williams git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 29 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2submodule: create helper to build paths to submodule gitdirsbuiltin/submodule--helper.c dir.c git-submodule.sh +4 more+75 -314 replies
2/2submodule: munge paths to submodule git directoriessubmodule.c t/t7400-submodule-basic.sh t/t7406-submodule-update.sh+51 -1627 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] munge submodule names

Here's a more polished series taking into account some of the feedback on the RFC. As Junio pointed out URL encoding makes the directories much more human readable, but I'm open to other ideas if we don't think URL encoding is the right thing to do.

Brandon Williams (2):
submodule: create helper to build paths to submodule gitdirs
submodule: munge paths to submodule git directories

 builtin/submodule--helper.c      | 28 +++++++++++--
 dir.c                            |  2 +-
 git-submodule.sh                 |  7 ++--
 repository.c                     |  3 +-
 submodule.c                      | 67 ++++++++++++++++++++++----------
 submodule.h                      |  7 ++++
 t/t7400-submodule-basic.sh       | 32 ++++++++++++++-
 t/t7406-submodule-update.sh      | 21 +++-------
 t/t7410-submodule-checkout-to.sh |  6 ++-
 9 files changed, 126 insertions(+), 47 deletions(-)
Signature · 1 line
2.18.0.597.ga71716f1ad-goog