Skip to content

BPF: New helper to obtain namespace data from current task

Carlos Neira bpf netdev 15 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v17 Latest3 patches 6 repliesIn review
  2. v165 patches 7 repliesSuperseded
  3. v155 patches 11 repliesSuperseded
Earlier versions · 12
VersionPostedPatchesRepliesStatus
v145 patches9 repliesSuperseded
v134 patches6 repliesSuperseded
v124 patches4 repliesSuperseded
v114 patches13 repliesSuperseded
v104 patches20 repliesSuperseded
v93 patches13 repliesSuperseded
v51 patch9 repliesSuperseded
v41 of 3 patches0 repliesSuperseded
v3 posting 2/21 of 3 patches4 repliesSuperseded
v3 posting 1/22 of 3 patches2 repliesSuperseded
v21 patch1 replySuperseded
v11 patch5 repliesSuperseded

Patches in v17 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3fs/nsfs.c: added ns_matchfs/nsfs.c include/linux/proc_ns.h+16 -00 replies
2/3bpf: added new helper bpf_get_ns_current_pid_tgidinclude/linux/bpf.h include/uapi/linux/bpf.h kernel/bpf/core.c +4 more+88 -20 replies
3/3tools/testing/selftests/bpf: Add self-tests for new helper bpf_get_ns_current_pid_tgid.tools/testing/selftests/bpf/Makefile tools/testing/selftests/bpf/prog_tests/ns_current_pid_tgid.c tools/testing/selftests/bpf/progs/test_ns_current_pid_tgid.c +1 more+286 -10 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchYonghong Song
1/3
2/3A-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v17 thread

Cover letter [PATCH v17 0/3] BPF: New helper to obtain namespace data from current task

Currently bpf_get_current_pid_tgid(), is used to do pid filtering in bcc's scripts but this helper returns the pid as seen by the root namespace which is fine when a bcc script is not executed inside a container.
When the process of interest is inside a container, pid filtering will not work if bpf_get_current_pid_tgid() is used.
This helper addresses this limitation returning the pid as it's seen by the current namespace where the script is executing.

In the future different pid_ns files may belong to different devices, according to the discussion between Eric Biederman and Yonghong in 2017 Linux plumbers conference. To address that situation the helper requires inum and dev_t from /proc/self/ns/pid. This helper has the same use cases as bpf_get_current_pid_tgid() as it can be used to do pid filtering even inside a container.

Carlos Neira (3):
fs/nsfs.c: added ns_match
bpf: added new helper bpf_get_ns_current_pid_tgid tools/testing/selftests/bpf: Add self-tests for new helper
bpf_get_ns_current_pid_tgid.

 fs/nsfs.c                                     |  14 ++
 include/linux/bpf.h                           |   1 +
 include/linux/proc_ns.h                       |   2 +
 include/uapi/linux/bpf.h                      |  20 ++-
 kernel/bpf/core.c                             |   1 +
 kernel/bpf/helpers.c                          |  45 +++++
 kernel/trace/bpf_trace.c                      |   2 +
 scripts/bpf_helpers_doc.py                    |   1 +
 tools/include/uapi/linux/bpf.h                |  20 ++-
 tools/testing/selftests/bpf/Makefile          |   3 +-
 .../bpf/prog_tests/ns_current_pid_tgid.c      |  88 ++++++++++
 .../bpf/progs/test_ns_current_pid_tgid.c      |  37 ++++
 .../bpf/test_current_pid_tgid_new_ns.c        | 159 ++++++++++++++++++
 13 files changed, 390 insertions(+), 3 deletions(-)
 create mode 100644 tools/testing/selftests/bpf/prog_tests/ns_current_pid_tgid.c
 create mode 100644 tools/testing/selftests/bpf/progs/test_ns_current_pid_tgid.c
 create mode 100644 tools/testing/selftests/bpf/test_current_pid_tgid_new_ns.c
Signature · 1 line
2.20.1