Skip to content

Fixes/Addition to use the USB Ethernet gadget with the DWC3 gadget controller

Lukasz Majewski u-boot 1 version New

Get series with b4
b4 am 20180811140438.1d015ef0@jawa

Versions newest first

  1. v4 Latest0 of 7 patches 0 repliesNew

Patches in v4 No applies recorded yet

None of the 7 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [U-Boot] [PATCH v4 0/7] Fixes/Addition to use the USB Ethernet gadget with the DWC3 gadget controller

Hi Jean-Jacques,

Quoted 11 lines

This series implements 2 fixes to be able to use USB Ethernet gadget with the dwc3 driver.
It also adds new commands to bind/unbind a device to/from a driver and update the 'dm tree' command to make it easier to use those new commands. The bind/unbind commands can be used to bind the DWC3 USB gadget to the usb_ether driver from the command line instead of relying on platform code.

Changes in v4:
- Fixed compiler warning: "cmd/bind.c:236:5: warning: ‘ret’ may be used uninitialized in this function [-Wmaybe-uninitialized]"

With the v3 Michal Simek asked (I was out of the office) if we shall wait for sandbox tests or not?

Is there any follow up plan for adding tests to sandbox?

Quoted 47 lines

Changes in v3:
- update commit log
- fixed problem with the function name
- update commit log
- new commit
- new
- factorize code based on comments from ML
- remove the devices before unbinding them
- use device_find_global_by_ofnode() to get a device by its node.

Changes in v2:
- Make the bind/unbind command generic, not specific to usb device.
- Update the API to be able to bind/unbind based on DTS node path
- Add a Kconfig option to select the bind/unbind commands

Jean-Jacques Hiblot (7):
usb: gadget: Add bcdDevice for the DWC3 USB Gadget Controller
net: eth-uclass: Fix for DM USB ethernet support
uclass: Add dev_get_uclass_index() to get the uclass/index of a
device dm: print the index of the device when dumping the dm tree
dm: convert device_get_global_by_of_offset() to
device_get_global_by_ofnode()
device: expose the functions used to remove and unbind children of a
device
cmd: Add bind/unbind commands to bind a device to a driver from the
command line

 arch/arm/mach-rockchip/rk3188-board-spl.c |   2 +-
 arch/arm/mach-rockchip/rk3288-board-spl.c |   2 +-
 arch/sandbox/dts/test.dts                 |  11 ++
 cmd/Kconfig                               |   9 ++
 cmd/Makefile                              |   1 +
 cmd/bind.c                                | 255
++++++++++++++++++++++++++++++
configs/sandbox_defconfig                 |   1 +
drivers/core/device-remove.c              |  30 ++--
drivers/core/device.c                     |  19 ++-
drivers/core/dump.c                       |  16 +-
drivers/core/uclass.c                     |  21 +++
drivers/usb/gadget/gadget_chips.h         |   2 +
include/dm/device-internal.h              |  38 +++++
include/dm/device.h                       |  23 ++-
include/dm/uclass-internal.h              |  11 ++
net/eth-uclass.c                          |   3 +-
test/py/tests/test_bind.py                | 178 +++++++++++++++++++++
17 files changed, 584 insertions(+), 38 deletions(-) create mode
Quoted 2 lines

100644 cmd/bind.c create mode 100644 test/py/tests/test_bind.py

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180811/122f5d89/attachment.sig>