Skip to content

staging: erofs: fix some issues and clean up codes

Chao Yu linux-erofs lkml 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 0 repliesNew
  2. v1 posting 2/21 of 8 patches 0 repliesSuperseded
  3. v1 posting 1/28 patches 20 repliesSuperseded

Changes in v2 from the cover letter

[PATCH 2/9] staging: erofs: separate erofs_get_meta_page
- Put err_out stuff at the bottom of the function.
- Drop the question mark in the "truncated by others?". Pointed out by Dan Carpenter <dan.carpenter at oracle.com>
- fix `PTR_ERR applied after initialization to constant'. Reported by kbuild test robot <lkp at intel.com>
- fix compilation error (erofs is bypassed by BROKEN...).

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9staging: erofs: introduce erofs_grab_biodrivers/staging/erofs/data.c drivers/staging/erofs/internal.h drivers/staging/erofs/unzip_vle.c+30 -220 replies
2/9staging: erofs: separate erofs_get_meta_pagedrivers/staging/erofs/Kconfig drivers/staging/erofs/data.c drivers/staging/erofs/internal.h +2 more+93 -390 replies
3/9staging: erofs: add error handling for xattr submoduledrivers/staging/erofs/internal.h drivers/staging/erofs/xattr.c+85 -430 replies
4/9staging: erofs: cleanup z_erofs_vle_work_{lookup, register}drivers/staging/erofs/unzip_vle.c+47 -420 replies
5/9staging: erofs: rearrange vle clustertype definitionsdrivers/staging/erofs/erofs_fs.h drivers/staging/erofs/unzip_vle.c+11 -80 replies
6/9staging: erofs: fix vle_decompressed_index_clusterofsdrivers/staging/erofs/unzip_vle.c+15 -110 replies
7/9staging: erofs: fix integer overflow on 32-bit platformdrivers/staging/erofs/unzip_vle.c+4 -40 replies
8/9staging: erofs: fix compression mapping beyond EOFdrivers/staging/erofs/unzip_vle.c+1 -10 replies
9/9staging: erofs: fix potential overflow in erofs_grab_bio()drivers/staging/erofs/internal.h+1 -10 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchChao YuGao Xiang
1/9R-b
2/9R-b
3/9R-b
4/9R-b
5/9R-b
6/9R-b
7/9R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/9] staging: erofs: fix some issues and clean up codes

From: Chao Yu <[email protected]>

This patchset mainly adds error handing code for erofs xattr subsystem. In addition, some code cleanups are also included in this patchset.

P.S. Some other patches are still previewing in the linux-erofs mailing list, which will be posted in the 2nd part later.

[changelog]
v1 -> v2:
[PATCH 2/9] staging: erofs: separate erofs_get_meta_page
- Put err_out stuff at the bottom of the function.
- Drop the question mark in the "truncated by others?". Pointed out by Dan Carpenter <dan.carpenter at oracle.com>
- fix `PTR_ERR applied after initialization to constant'. Reported by kbuild test robot <lkp at intel.com>
- fix compilation error (erofs is bypassed by BROKEN...).

[PATCH 3/9] staging: erofs: add error handling for xattr submodule
- drop all likely/unlikely hints in this patch.
- fix bare use of 'unsigned *' at drivers/staging/erofs/xattr.c:168. Pointed out by Dan Carpenter <dan.carpenter at oracle.com>

[PATCH 6/9] staging: erofs: fix vle_decompressed_index_clusterofs
- don't make functions inline
Pointed out by Dan Carpenter <dan.carpenter at oracle.com>

[PATCH 9/9] staging: erofs: fix potential overflow in erofs_grab_bio()
- in addition, we add one more patch above to fix potential overflow in this series.

Chao Yu (1):
staging: erofs: fix potential overflow in erofs_grab_bio()

Gao Xiang (8):
staging: erofs: introduce erofs_grab_bio
staging: erofs: separate erofs_get_meta_page
staging: erofs: add error handling for xattr submodule
staging: erofs: cleanup z_erofs_vle_work_{lookup, register}
staging: erofs: rearrange vle clustertype definitions
staging: erofs: fix vle_decompressed_index_clusterofs
staging: erofs: fix integer overflow on 32-bit platform
staging: erofs: fix compression mapping beyond EOF

 drivers/staging/erofs/Kconfig     |   9 ++
 drivers/staging/erofs/data.c      |  68 +++++++++-----
 drivers/staging/erofs/erofs_fs.h  |  11 +++
 drivers/staging/erofs/internal.h  |  66 ++++++++-----
 drivers/staging/erofs/unzip_vle.c | 149 +++++++++++++++---------------
 drivers/staging/erofs/xattr.c     | 127 +++++++++++++++++--------
 6 files changed, 273 insertions(+), 157 deletions(-)
Signature · 1 line
2.18.0