Skip to content

staging: mt7621-mmc: Fix debug macros and their usages

Nishad Kamdar lkml 6 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest1 patch 0 repliesNew
  2. v71 patch 2 repliesSuperseded
  3. v63 patches 2 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v54 patches2 repliesSuperseded
v44 patches9 repliesSuperseded
v31 patch4 repliesSuperseded

Changes in v8 from the cover letter

- Remove unnecessary {} for single statement if

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1staging: mt7621-mmc: Delete IRQ_MSG() and its usersdrivers/staging/mt7621-mmc/dbg.h drivers/staging/mt7621-mmc/sd.c+2 -340 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v8 yet.

Read the v8 thread

Cover letter [PATCH v8 0/1] staging: mt7621-mmc: Fix debug macros and their usages

This patch fixes the debug macro IRQ_MSG().
It deletes IRQ_MSG() and all its users as currently it is a no-op.

Changes in v8:
- Remove unnecessary {} for single statement if

Changes in v7:
- Delete IRQ_MSG() macro and its users.
- Patchset reduced to 1 patch as the patches fixing N_MSG() and ERR_MSG() have been accepted.

Changes in v6:
- Delete N_MSG() macro and its users as it is a no-op.
- Patchset reduced to 3 patches as the INIT_MSG patch is accepted.

Changes in v5:
- Remove commented code for N_MSG().
- Remove commented ERR_MSG() usages.

Changes in v4:
- Create multiple patches, one for each type of macro being deleted/changed.

Changes in v3:
- Replace usages of ERR_MSG and IRQ_MSG with dev_err() in code itself.
- Remove all INIT_MSG usages.
- Drop ERR_MSG, INIT_MSG and IRQ_MSG from dbg.h.

Changes in v2:
- Replace printk with dev_<level>.
- Remove __func__, __LINE__, current->comm, current->pid from arguments.
- Remove the do {} while(0) loop from these macros.
- Modify commit message to include other changes.

Nishad Kamdar (1):
staging: mt7621-mmc: Delete IRQ_MSG() and its users

 drivers/staging/mt7621-mmc/dbg.h | 12 ------------
 drivers/staging/mt7621-mmc/sd.c  | 24 ++----------------------
 2 files changed, 2 insertions(+), 34 deletions(-)
Signature · 1 line
2.17.1