Introduce AVTP Audio Format (AAF) plugin
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest posting 2/27 patches 4 repliesIn review
- v2 RFC posting 1/25 patches 0 repliesSuperseded
- v1 RFC5 patches 21 repliesSuperseded
Patches in v2 posting 2/2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | aaf: Introduce plugin skeletonMakefile.am aaf/ aaf/ +2 more | +125 | 0 replies | |
| 2/7 | aaf: Load configuration parametersaaf/ configure.ac doc/ | +164 | 0 replies | |
| 3/7 | aaf: Implement Playback mode supportaaf/ configure.ac doc/ | +744 | 0 replies | |
| 4/7 | aaf: Prepare for Capture mode supportaaf/ | +94 | 0 replies | |
| 5/7 | aaf: Implement Capture mode supportaaf/ doc/ | +400 | 0 replies | |
| 6/7 | aaf: Implement dump() ioplug callbackaaf/ | +24 | 0 replies | |
| 7/7 | aaf: Add support for direct read/write transfersaaf/ | +4 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 - AAF PCM plugin 0/7] Introduce AVTP Audio Format (AAF) plugin
Hi all,
This new version addresses the feedback from v1 and fixes a bug on capture mode. Code-wise, the changes are very trivial, no major diffs. Below follows the highlights:
* Standard headers like linux/if_ether.h are now checked by configure script.
* The 'static' modifier was added to array variables in aaf_hw_constraint().
* aaf_close() callback was simplified.
* aaf_rx_pdu() was modified so it doesn't return an error in case the number of bytes read by recv() is different from aaf->pdu_size. This is an expected situation and it means the received AVTPDU doesn't belong to the AAF stream the plugin is interested in so it should simply drop that AVTPDU. This fixes a bug when running multiple streams (with different AVPTU sizes) concurrently.
Additionally, this new version improves the instructions in doc/aaf.txt in order to make it easier to test the plugin. Anyone should be able to test it just by copying and pasting the instructions.
To recap what has been discussed about the plugin so far, check the comments in RFC and PATCH series archive [1-3]. All versions of this series can be also found in my alsa-plugins tree in github [4].
Regards,
Andre
[1] http://mailman.alsa-project.org/pipermail/alsa-devel/2018-August/139494.html
[2] http://mailman.alsa-project.org/pipermail/alsa-devel/2018-September/140290.html
[3] http://mailman.alsa-project.org/pipermail/alsa-devel/2018-October/140667.html
[4] https://github.com/aguedes/alsa-plugins
Andre Guedes (7):
aaf: Introduce plugin skeleton
aaf: Load configuration parameters
aaf: Implement Playback mode support
aaf: Prepare for Capture mode support
aaf: Implement Capture mode support
aaf: Implement dump() ioplug callback
aaf: Add support for direct read/write transfers
Makefile.am | 3 + aaf/Makefile.am | 9 + aaf/pcm_aaf.c | 1200 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ configure.ac | 11 + doc/aaf.txt | 157 ++++++++ 5 files changed, 1380 insertions(+) create mode 100644 aaf/Makefile.am create mode 100644 aaf/pcm_aaf.c create mode 100644 doc/aaf.txt
Signature · 1 line
2.14.4