Skip to content

RATP i2c and GPIO support

Aleksander Morgado barebox 2 versions – Applied

Status from this message: Applied, thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 1 replyApplied
  2. v14 patches 7 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/7ratp: implement i2c read/write supportcommon/ratp/Kconfig common/ratp/Makefile common/ratp/i2c.c +1 more+296 -00 replies
2/7bbremote: implement i2c read/write supportscripts/remote/controller.py scripts/remote/main.py scripts/remote/messages.py+147 -00 replies
3/7ratp: implement support for GPIO commandscommon/ratp/Kconfig common/ratp/Makefile common/ratp/gpio.c +1 more+160 -10 replies
4/7bbremote: implement support for GPIO operationsscripts/remote/controller.py scripts/remote/main.py scripts/remote/messages.py+166 -00 replies
5/7ratp: use __packed instead of the full formcommon/ratp/md.c common/ratp/mw.c common/ratp/reset.c+5 -50 replies
6/7ratp: use pr_ macros to print messagescommon/ratp/md.c common/ratp/mw.c common/ratp/reset.c+19 -130 replies
7/7ratp: fix incorrect whitespaces in method callscommon/ratp/getenv.c common/ratp/md.c common/ratp/mw.c +1 more+15 -150 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/7] RATP i2c and GPIO support

This series of patches implements support for i2c and GPIO operations via RATP.

It addresses most of the comments from the first series review, except for Sascha's suggestion to implement name resolving for the i2c buses and Andrey's suggestion to prepare a new helper method to initialize the i2c_client structure. I already have a patch for the latter, but will send it for review once these have been accepted and merged, as it's really a bit orthogonal to the whole RATP logic.

Another different w.r.t. v1 apart from addressing the comments is the review is that I made the RATP i2c support depend on CONFIG_I2C and the RATP GPIO support on CONFIG_GENERIC_GPIO. That was missing, and was breaking build if RATP was selected but no i2c or GPIO support was included in the build.

Comments welcome!

Aleksander Morgado (7):
ratp: implement i2c read/write support
bbremote: implement i2c read/write support
ratp: implement support for GPIO commands
bbremote: implement support for GPIO operations
ratp: use __packed instead of the full form
ratp: use pr_ macros to print messages
ratp: fix incorrect whitespaces in method calls

 common/ratp/Kconfig          |  15 ++
 common/ratp/Makefile         |   2 +
 common/ratp/getenv.c         |  12 +-
 common/ratp/gpio.c           | 144 ++++++++++++++++++
 common/ratp/i2c.c            | 284 +++++++++++++++++++++++++++++++++++
 common/ratp/md.c             |  24 +--
 common/ratp/mw.c             |  24 +--
 common/ratp/reset.c          |  10 +-
 include/ratp_bb.h            |  10 ++
 scripts/remote/controller.py |  60 ++++++++
 scripts/remote/main.py       |  74 +++++++++
 scripts/remote/messages.py   | 179 ++++++++++++++++++++++
 12 files changed, 806 insertions(+), 32 deletions(-)
 create mode 100644 common/ratp/gpio.c
 create mode 100644 common/ratp/i2c.c
Signature · 7 lines
2.19.0


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox