btrfs-progs related improvements
Get series with b4
b4 am 20180821220840.GT15347@scaerVersions newest first
- v1 Latest4 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | lzo: build shared library for the host | +0 | 0 replies | |
| 2/4 | e2fsprogs: build shared library for the host | +0 | 1 reply | |
| 3/4 | btrfs-progs: drop dependency on e2fsprogs by not building btrfs-convert | +0 | 0 replies | |
| 4/4 | btrfs-progs: make e2fsprogs an optional dependency | +0 | 0 replies |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Yann E. MORIN |
|---|---|
| 1/4 | A-b |
| 2/4 | R-b |
| 3/4 | R-b |
| 4/4 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Buildroot] [PATCH next 0/4] btrfs-progs related improvements
Thomas, All,
On 2018-08-21 23:59 +0200, Thomas Petazzoni spake thusly:
Quoted 19 lines
Following the addition of host-btrfs-progs recently by Robert J. Heywood, I wondered why e2fsprogs was needed as a dependency. Indeed, why would btrfs need the library of a completely different filesystem?
Turns out it's because btrfs-progs can optionally build a tool called btrfs-convert, to convert an ext2 or reiserfs filesystem to a btrfs one, and this tool needs e2fsprogs as a dependency to support ext2 filesystem conversion. But this is completely optional.
For the host variant, I don't think it makes sense to support that at all, so we forcibly disable building btrfs-convert.
For the target variant, e2fsprogs is turned into an automatic optional
dependency: when available, btrfs-convert is compiled with ext2 support, otherwise btrfs-convert is not built at all. We don't take into account reiserfs support because we don't have the corresponding libraries packaged in Buildroot.
Quoted 3 lines
While doing this work on the host variant, I noticed the e2fsprogs and lzo host libraries were only available as static libraries. So I went ahead and fixed that as well.
There is one thing you forgot to do: enable support for zstd, now that we have a package for it. ;-p
Regards,
Yann E. MORIN.
Quoted 24 lines
Best regards,
Thomas
Thomas Petazzoni (4):
lzo: build shared library for the host
e2fsprogs: build shared library for the host
btrfs-progs: drop dependency on e2fsprogs by not building
btrfs-convert
btrfs-progs: make e2fsprogs an optional dependencypackage/btrfs-progs/Config.in | 1 - package/btrfs-progs/btrfs-progs.mk | 20 +++++++++++++++++--- package/e2fsprogs/e2fsprogs.mk | 3 ++- package/lzo/lzo.mk | 2 ++ 4 files changed, 21 insertions(+), 5 deletions(-)Signature · 6 lines
2.14.4 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'