Skip to content

tcp_bbr: PROBE_RTT minor bug fixes

Kevin Yang netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3tcp_bbr: add bbr_check_probe_rtt_done() helpernet/ipv4/tcp_bbr.c+18 -160 replies
2/3tcp_bbr: in restart from idle, see if we should exit PROBE_RTTnet/ipv4/tcp_bbr.c+4 -00 replies
3/3tcp_bbr: apply PROBE_RTT cwnd cap even if acked==0net/ipv4/tcp_bbr.c+2 -20 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchSoheil Hassas YeganehYuchung Cheng
1/3R-b
2/3R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net 0/3] tcp_bbr: PROBE_RTT minor bug fixes

From: "Kevin(Yudong) Yang" <[email protected]>

This series includes two minor bug fixes for the TCP BBR PROBE_RTT mechanism, and one preparatory patch:

(1) A preparatory patch to reorganize the PROBE_RTT logic by refactoring (into its own function) the code to exit PROBE_RTT, since the next patch will be using that code in a new context.

(2) Fix: When BBR restarts from idle and if BBR is in PROBE_RTT mode, BBR should check if it's time to exit PROBE_RTT. If yes, then BBR should exit PROBE_RTT mode and restore the cwnd to its full value.

(3) Fix: Apply the PROBE_RTT cwnd cap even if the count of fully-ACKed packets is 0.

Kevin Yang (3):
tcp_bbr: add bbr_check_probe_rtt_done() helper
tcp_bbr: in restart from idle, see if we should exit PROBE_RTT
tcp_bbr: apply PROBE_RTT cwnd cap even if acked==0

 net/ipv4/tcp_bbr.c | 42 ++++++++++++++++++++++++------------------
 1 file changed, 24 insertions(+), 18 deletions(-)
Signature · 1 line
2.18.0.1017.ga543ac7ca45-goog