Skip to content

jobs: Job Exit Refactoring Pt 2

John Snow qemu-devel 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest16 patches 19 repliesIn review
  2. v415 patches 15 repliesSuperseded
  3. v3 posting 2/215 patches 14 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v3 posting 1/29 patches14 repliesSuperseded
v213 patches14 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16block/commit: add block job creation flagsblock/commit.c blockdev.c include/block/block_int.h+11 -60 replies
2/16block/mirror: add block job creation flagsblock/mirror.c blockdev.c include/block/block_int.h+9 -40 replies
3/16block/stream: add block job creation flagsblock/stream.c blockdev.c include/block/block_int.h+9 -40 replies
4/16block/commit: refactor commit to use job callbacksblock/commit.c+51 -412 replies
5/16block/mirror: don't install backing chain on abortblock/mirror.c+1 -12 replies
6/16block/mirror: conservative mirror_exit refactorblock/mirror.c+28 -113 replies
7/16block/stream: refactor stream to use job callbacksblock/stream.c+15 -81 reply
8/16tests/blockjob: replace Blockjob with Jobtests/test-blockjob.c+50 -481 reply
9/16tests/test-blockjob: remove exit callbacktests/test-blockjob.c+6 -101 reply
10/16tests/test-blockjob-txn: move .exit to .cleantests/test-blockjob-txn.c+2 -21 reply
11/16jobs: remove .exit callbackinclude/qemu/job.h job.c+34 -541 reply
12/16qapi/block-commit: expose new job propertiesblockdev.c qapi/block-core.json+23 -11 reply
13/16qapi/block-mirror: expose new job propertiesblockdev.c qapi/block-core.json+42 -21 reply
14/16qapi/block-stream: expose new job propertiesblockdev.c hmp.c qapi/block-core.json+27 -31 reply
15/16block/backup: qapi documentation fixupqapi/block-core.json+10 -81 reply
16/16blockdev: document transactional shortcomingsblockdev.c+7 -12 replies

Reviews trailers per patch

All 16 patches have a Reviewed-by or Acked-by.

PatchMax ReitzJeff Cody
1/16R-b R-b
2/16R-b R-b
3/16R-b R-b
4/16R-b R-b
5/16R-b R-b
6/16R-b R-b
7/16R-b R-b
8/16R-b R-b
9/16R-b R-b
10/16R-b R-b
11/16R-b R-b
12/16R-b R-b
13/16R-b R-b
14/16R-b R-b
15/16R-b R-b
16/16R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [Qemu-devel] [PATCH v5 00/16] jobs: Job Exit Refactoring Pt 2

This is part two of a two part series that refactors the exit logic of jobs.

This series forces all jobs to use the "finalize" semantics that were introduced previously, but only exposed via the backup jobs.

Patches 1-3 add plumbing for the auto-dismiss and auto-finalize flags but do not expose these via QAPI/QMP.

Patches 4-7 refactor the .exit() callbacks into the component pieces of .prepare(), .commit(), .abort() and .clean(). Except mirror, which I cheat with.

Patches 8-10 remove the last usages of .exit in a test. Patche 11 removes the .exit callback and the machinery to invoke it.

Patches 12-14 expose the new QMP options to all of the jobs. Patch 15 is a doc fixup.

====
"V5"
====

Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/16:[----] [--] 'block/commit: add block job creation flags' 002/16:[----] [--] 'block/mirror: add block job creation flags' 003/16:[----] [--] 'block/stream: add block job creation flags' 004/16:[0002] [FC] 'block/commit: refactor commit to use job callbacks' 005/16:[0005] [FC] 'block/mirror: don't install backing chain on abort' 006/16:[0005] [FC] 'block/mirror: conservative mirror_exit refactor' 007/16:[----] [--] 'block/stream: refactor stream to use job callbacks' 008/16:[----] [--] 'tests/blockjob: replace Blockjob with Job' 009/16:[----] [--] 'tests/test-blockjob: remove exit callback' 010/16:[----] [--] 'tests/test-blockjob-txn: move .exit to .clean' 011/16:[----] [--] 'jobs: remove .exit callback' 012/16:[----] [--] 'qapi/block-commit: expose new job properties' 013/16:[----] [--] 'qapi/block-mirror: expose new job properties' 014/16:[----] [--] 'qapi/block-stream: expose new job properties' 015/16:[----] [--] 'block/backup: qapi documentation fixup' 016/16:[down] 'blockdev: document transactional shortcomings'

004: Add FIXME comment (Jeff)
005: Update commit message, move ternary touchup to next patch (Max) 006: Adopt ternary fixup from previous patch (Max)
016: New, does what it says on the tin (Max)

====
"V4"
====

002, 003: Fix typo (Eric)
005: Don't not install the backing chain if
we cancel a successful job (Max)
006: Fallout from 005
007: Fixed commit title. (Max)

====
"V3"
====

000: Fixed my cover letter subject. Phew!
004: Adjusted comment, added R-B
005: New; based on discussions from what is now 006 (was 005) 006: mirror_exit_common returns ret == 0 if we are aborting
and it aborts successfully (Max)
Added assertion that we aborted successfully (Max)
010: New, minor cleanup before we can actually remove .exit. 011: Removed what's now patch 10, added R-B per Max's comment.

=====
"V2":
=====
- Split off the first part of the series to Pt.1
- More aggressively refactored .commit()
- Went all the way to deleting .exit() callback (Kevin)

John Snow (16):
block/commit: add block job creation flags block/mirror: add block job creation flags block/stream: add block job creation flags block/commit: refactor commit to use job callbacks block/mirror: don't install backing chain on abort block/mirror: conservative mirror_exit refactor block/stream: refactor stream to use job callbacks tests/blockjob: replace Blockjob with Job tests/test-blockjob: remove exit callback tests/test-blockjob-txn: move .exit to .clean
jobs: remove .exit callback qapi/block-commit: expose new job properties qapi/block-mirror: expose new job properties qapi/block-stream: expose new job properties block/backup: qapi documentation fixup
blockdev: document transactional shortcomings

 block/commit.c            |  97 ++++++++++++++++++++++-----------------
 block/mirror.c            |  44 ++++++++++++------
 block/stream.c            |  28 ++++++++----
 blockdev.c                |  52 ++++++++++++++++++---
 hmp.c                     |   5 +-
 include/block/block_int.h |  15 ++++--
 include/qemu/job.h        |  11 -----
 job.c                     |  77 ++++++++++++++-----------------
 qapi/block-core.json      |  80 +++++++++++++++++++++++++++-----
 tests/test-blockjob-txn.c |   4 +-
 tests/test-blockjob.c     | 114 +++++++++++++++++++++++-----------------------
 11 files changed, 324 insertions(+), 203 deletions(-)
Signature · 1 line
2.14.4