Skip to content

use oidset for skiplist + docs + tests + comment support

Ævar Arnfjörð Bjarmason git 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest10 patches 0 repliesNew
  2. v48 patches 1 replySuperseded
  3. v37 patches 3 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10fsck tests: setup of bogus commit objectt/t5504-fetch-receive-strict.sh+4 -40 replies
2/10fsck tests: add a test for no skipList inputt/t5504-fetch-receive-strict.sh+5 -00 replies
3/10fsck: document and test sorted skipList inputDocumentation/config.txt t/t5504-fetch-receive-strict.sh+28 -10 replies
4/10fsck: document and test commented & empty line skipList inputDocumentation/config.txt t/t5504-fetch-receive-strict.sh+28 -40 replies
5/10fsck: document that skipList input must be unabbreviatedDocumentation/config.txt t/t5504-fetch-receive-strict.sh+7 -10 replies
6/10fsck: add a performance testt/perf/p1450-fsck.sh+13 -00 replies
7/10fsck: add a performance test for skipListt/perf/p1451-fsck-skip-list.sh+40 -00 replies
8/10fsck: use strbuf_getline() to read skiplist filefsck.c t/t5504-fetch-receive-strict.sh+13 -140 replies
9/10fsck: use oidset instead of oid_array for skipListDocumentation/config.txt fsck.c fsck.h+13 -290 replies
10/10fsck: support comments & empty lines in skipListDocumentation/config.txt fsck.c t/t5504-fetch-receive-strict.sh+33 -50 replies

Reviews trailers per patch

None of the 10 patches has a Reviewed-by or Acked-by.

PatchÆvar Arnfjörð BjarmasonJeff King
1/10
2/10
3/10
4/10
5/10
6/10
7/10
8/10Helped-by
9/10Helped-by
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 00/10] use oidset for skiplist + docs + tests + comment support

Addresses feedback René had on v4. Notes below:

René Scharfe (3):
fsck: add a performance test for skipList
fsck: use strbuf_getline() to read skiplist file

No changes.

fsck: use oidset instead of oid_array for skipList

Now we note in the commit message that the skipList is re-consulted for .gitmodules blobs, as René pointed out.

Ævar Arnfjörð Bjarmason (7):
fsck tests: setup of bogus commit object
fsck tests: add a test for no skipList input

No changes.

fsck: document and test sorted skipList input

Trivial whitespace change in new docs paragraph.

fsck: document and test commented & empty line skipList input

No changes.

fsck: document that skipList input must be unabbreviated

NEW: Now we document & test for the SHA-1s on the skip list being unabbreviated. It was always like this, but let's say so / test for it.

fsck: add a performance test

NEW: Add a generic new fsck perf test while I'm at it, in addition to the more specific one René wrote.

fsck: support comments & empty lines in skipList

The major change this time around, we now support trailing comments, leading whitespace before comments, whitespace-only lines etc. I went one step further than what René suggested and decided to just call strbuf_trim() so now we also support SHA-1s with leading spaces. I don't see a good reason to go out of our way to ban those, and it's consistent with other formats we use (and perhaps people will use this to align them in some way).

 Documentation/config.txt        | 23 ++++++++---
 fsck.c                          | 60 +++++++++++++--------------
 fsck.h                          |  8 ++--
 t/perf/p1450-fsck.sh            | 13 ++++++
 t/perf/p1451-fsck-skip-list.sh  | 40 ++++++++++++++++++
 t/t5504-fetch-receive-strict.sh | 72 +++++++++++++++++++++++++++++++--
 6 files changed, 171 insertions(+), 45 deletions(-)
 create mode 100755 t/perf/p1450-fsck.sh
 create mode 100755 t/perf/p1451-fsck-skip-list.sh
Signature · 1 line
2.19.0.rc1.350.ge57e33dbd1