Skip to content

compat_ioctl: cleanups

Arnd Bergmann alsa-devel amd-gfx ceph-devel dri-devel kvm linux-arm-kernel linux-bluetooth linux-btrfs linux-crypto linux-doc linux-fbdev linux-fsdevel linux-ide linux-iio linux-input linux-integrity linux-media linux-mtd linux-nvdimm linux-pci linux-ppp linux-rdma linux-remoteproc linux-rtc linux-s390 linux-scsi linux-um linux-usb linux-wireless linuxppc-dev lkml netdev nvdimm platform-driver-x86 sparclinux stable virtualization 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest26 patches 38 repliesIn review
  2. v15 patches 7 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/26compat_ioctl: pppoe: fix PPPOEIOCSFWD handlingdrivers/net/ppp/pppoe.c fs/compat_ioctl.c include/linux/if_pppox.h+7 -10 replies
2/26compat_ioctl: move simple ppp command handling into driverdrivers/net/ppp/ppp_generic.c drivers/net/ppp/pppoe.c drivers/net/ppp/pptp.c +2 more+10 -315 replies
3/26compat_ioctl: avoid unused function warning for do_ioctlfs/compat_ioctl.c+1 -10 replies
4/26compat_ioctl: move PPPIOCSCOMPRESS32 to ppp-generic.cdrivers/net/ppp/ppp_generic.c fs/compat_ioctl.c+35 -372 replies
5/26compat_ioctl: move PPPIOCSPASS32/PPPIOCSACTIVE32 to ppp_generic.cdrivers/net/ppp/ppp_generic.c fs/compat_ioctl.c+34 -420 replies
6/26compat_ioctl: handle PPPIOCGIDLE for 64-bit time_tDocumentation/networking/ppp_generic.txt drivers/isdn/i4l/isdn_ppp.c drivers/net/ppp/ppp_generic.c +3 more+43 -390 replies
7/26compat_ioctl: move rtc handling into rtc-dev.cdrivers/rtc/dev.c drivers/rtc/rtc-vr41xx.c fs/compat_ioctl.c+25 -590 replies
8/26compat_ioctl: add compat_ptr_ioctl()fs/compat_ioctl.c include/linux/fs.h+17 -02 replies
9/26compat_ioctl: move drivers to compat_ptr_ioctldrivers/char/ppdev.c drivers/char/tpm/tpm_vtpm_proxy.c drivers/firewire/core-cdev.c +13 more+20 -2378 replies
9/26compat_ioctl: move drivers to compat_ptr_ioctldrivers/char/ppdev.c drivers/char/tpm/tpm_vtpm_proxy.c drivers/firewire/core-cdev.c +13 more+20 -2370 replies
10/26compat_ioctl: use correct compat_ptr() translation in driversdrivers/misc/cxl/flash.c drivers/misc/genwqe/card_dev.c drivers/scsi/megaraid/megaraid_mm.c +1 more+4 -671 reply
11/26ceph: fix compat_ioctl for ceph_dir_operationsfs/ceph/dir.c+1 -02 replies
12/26compat_ioctl: move more drivers to compat_ptr_ioctldrivers/android/binder.c drivers/crypto/qat/qat_common/adf_ctl_drv.c drivers/dma-buf/dma-buf.c +33 more+39 -579 replies
13/26compat_ioctl: move tape handling into driversdrivers/ide/ide-tape.c drivers/s390/char/tape_char.c drivers/scsi/osst.c +3 more+137 -1320 replies
14/26compat_ioctl: move ATYFB_CLK handling to atyfb driverdrivers/video/fbdev/aty/atyfb_base.c fs/compat_ioctl.c+11 -33 replies
15/26compat_ioctl: move isdn/capi ioctl translation into driverdrivers/isdn/capi/capi.c fs/compat_ioctl.c+31 -170 replies
16/26compat_ioctl: move rfcomm handlers into driverfs/compat_ioctl.c net/bluetooth/rfcomm/sock.c+12 -80 replies
17/26compat_ioctl: move hci_sock handlers into driverfs/compat_ioctl.c net/bluetooth/hci_sock.c+20 -250 replies
18/26compat_ioctl: remove HCIUART handlingfs/compat_ioctl.c+0 -130 replies
19/26compat_ioctl: remove HIDIO translationfs/compat_ioctl.c+0 -170 replies
20/26compat_ioctl: remove translation for sound ioctlsarch/um/drivers/hostaudio_kern.c fs/compat_ioctl.c sound/core/oss/pcm_oss.c +1 more+7 -1583 replies
21/26compat_ioctl: remove IGNORE_IOCTL()fs/compat_ioctl.c+0 -560 replies
22/26compat_ioctl: remove /dev/random commandsdrivers/char/random.c fs/compat_ioctl.c+1 -70 replies
23/26compat_ioctl: remove joystick ioctl translationfs/compat_ioctl.c+0 -70 replies
24/26compat_ioctl: remove PCI ioctl translationfs/compat_ioctl.c+0 -60 replies
25/26compat_ioctl: remove /dev/raw ioctl translationfs/compat_ioctl.c+0 -40 replies
26/26compat_ioctl: remove last RAID handling codefs/compat_ioctl.c+0 -130 replies

Reviews trailers per patch

10 of 27 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchGreg Kroah-HartmanJarkko SakkinenJason GunthorpeAndrew DonnellanFelipe BalbiYan, ZhengGuillaume NaultAlexandre BelloniDaniel VetterMauro Carvalho ChehabDavid SterbaDarren Hart (VMware)Jonathan CameronBjorn AnderssonJiri KosinaTakashi IwaiStefan HajnocziMichael S. TsirkinTomas WinklerAndy ShevchenkoBartlomiej Zolnierkiewicz
SeriesA-b
1/26A-b
2/26
3/26
4/26
5/26
6/26
7/26A-b
8/26
9/26A-b A-b R-b R-b R-b R-b R-b R-b R-b R-b A-b A-b A-b A-b
9/26A-b A-b R-b R-b R-b R-b R-b R-b R-b R-b A-b A-b A-b A-b
10/26A-b A-b A-b
11/26R-b
12/26A-b A-b A-b A-b A-b A-b A-b A-b A-b
13/26
14/26A-b
15/26
16/26
17/26
18/26
19/26
20/26R-b
21/26
22/26A-b
23/26
24/26
25/26
26/26

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 21 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/26] compat_ioctl: cleanups

Hi Al,

It took me way longer than I had hoped to revisit this series, see
https://lore.kernel.org/lkml/[email protected]/
for the previously posted version.

I've come to the point where all conversion handlers and most COMPATIBLE_IOCTL() entries are gone from this file, but for now, this series only has the parts that have either been reviewed previously, or that are simple enough to include.

The main missing piece is the SG_IO/SG_GET_REQUEST_TABLE conversion. I'll post the patches I made for that later, as they need more testing and review from the scsi maintainers.

I hope you can still take these for the coming merge window, unless new problems come up.

Arnd

Arnd Bergmann (26):
compat_ioctl: pppoe: fix PPPOEIOCSFWD handling
compat_ioctl: move simple ppp command handling into driver
compat_ioctl: avoid unused function warning for do_ioctl
compat_ioctl: move PPPIOCSCOMPRESS32 to ppp-generic.c
compat_ioctl: move PPPIOCSPASS32/PPPIOCSACTIVE32 to ppp_generic.c
compat_ioctl: handle PPPIOCGIDLE for 64-bit time_t
compat_ioctl: move rtc handling into rtc-dev.c
compat_ioctl: add compat_ptr_ioctl()
compat_ioctl: move drivers to compat_ptr_ioctl
compat_ioctl: use correct compat_ptr() translation in drivers
ceph: fix compat_ioctl for ceph_dir_operations
compat_ioctl: move more drivers to compat_ptr_ioctl
compat_ioctl: move tape handling into drivers
compat_ioctl: move ATYFB_CLK handling to atyfb driver
compat_ioctl: move isdn/capi ioctl translation into driver
compat_ioctl: move rfcomm handlers into driver
compat_ioctl: move hci_sock handlers into driver
compat_ioctl: remove HCIUART handling
compat_ioctl: remove HIDIO translation
compat_ioctl: remove translation for sound ioctls
compat_ioctl: remove IGNORE_IOCTL()
compat_ioctl: remove /dev/random commands
compat_ioctl: remove joystick ioctl translation
compat_ioctl: remove PCI ioctl translation
compat_ioctl: remove /dev/raw ioctl translation
compat_ioctl: remove last RAID handling code

 Documentation/networking/ppp_generic.txt    |   2 +
 arch/um/drivers/hostaudio_kern.c            |   1 +
 drivers/android/binder.c                    |   2 +-
 drivers/char/ppdev.c                        |  12 +-
 drivers/char/random.c                       |   1 +
 drivers/char/tpm/tpm_vtpm_proxy.c           |  12 +-
 drivers/crypto/qat/qat_common/adf_ctl_drv.c |   2 +-
 drivers/dma-buf/dma-buf.c                   |   4 +-
 drivers/dma-buf/sw_sync.c                   |   2 +-
 drivers/dma-buf/sync_file.c                 |   2 +-
 drivers/firewire/core-cdev.c                |  12 +-
 drivers/gpu/drm/amd/amdkfd/kfd_chardev.c    |   2 +-
 drivers/hid/hidraw.c                        |   4 +-
 drivers/hid/usbhid/hiddev.c                 |  11 +-
 drivers/hwtracing/stm/core.c                |  12 +-
 drivers/ide/ide-tape.c                      |  31 +-
 drivers/iio/industrialio-core.c             |   2 +-
 drivers/infiniband/core/uverbs_main.c       |   4 +-
 drivers/isdn/capi/capi.c                    |  31 +
 drivers/isdn/i4l/isdn_ppp.c                 |  14 +-
 drivers/media/rc/lirc_dev.c                 |   4 +-
 drivers/mfd/cros_ec_dev.c                   |   4 +-
 drivers/misc/cxl/flash.c                    |   8 +-
 drivers/misc/genwqe/card_dev.c              |  23 +-
 drivers/misc/mei/main.c                     |  22 +-
 drivers/misc/vmw_vmci/vmci_host.c           |   2 +-
 drivers/mtd/ubi/cdev.c                      |  36 +-
 drivers/net/ppp/ppp_generic.c               |  99 +++-
 drivers/net/ppp/pppoe.c                     |   7 +
 drivers/net/ppp/pptp.c                      |   3 +
 drivers/net/tap.c                           |  12 +-
 drivers/nvdimm/bus.c                        |   4 +-
 drivers/nvme/host/core.c                    |   2 +-
 drivers/pci/switch/switchtec.c              |   2 +-
 drivers/platform/x86/wmi.c                  |   2 +-
 drivers/rpmsg/rpmsg_char.c                  |   4 +-
 drivers/rtc/dev.c                           |  13 +-
 drivers/rtc/rtc-vr41xx.c                    |  10 +
 drivers/s390/char/tape_char.c               |  41 +-
 drivers/sbus/char/display7seg.c             |   2 +-
 drivers/sbus/char/envctrl.c                 |   4 +-
 drivers/scsi/3w-xxxx.c                      |   4 +-
 drivers/scsi/cxlflash/main.c                |   2 +-
 drivers/scsi/esas2r/esas2r_main.c           |   2 +-
 drivers/scsi/megaraid/megaraid_mm.c         |  28 +-
 drivers/scsi/osst.c                         |  34 +-
 drivers/scsi/pmcraid.c                      |   4 +-
 drivers/scsi/st.c                           |  35 +-
 drivers/staging/android/ion/ion.c           |   4 +-
 drivers/staging/pi433/pi433_if.c            |  12 +-
 drivers/staging/vme/devices/vme_user.c      |   2 +-
 drivers/tee/tee_core.c                      |   2 +-
 drivers/usb/class/cdc-wdm.c                 |   2 +-
 drivers/usb/class/usbtmc.c                  |   4 +-
 drivers/usb/core/devio.c                    |  16 +-
 drivers/usb/gadget/function/f_fs.c          |  12 +-
 drivers/vfio/vfio.c                         |  39 +-
 drivers/vhost/net.c                         |  12 +-
 drivers/vhost/scsi.c                        |  12 +-
 drivers/vhost/test.c                        |  12 +-
 drivers/vhost/vsock.c                       |  12 +-
 drivers/video/fbdev/aty/atyfb_base.c        |  12 +-
 drivers/virt/fsl_hypervisor.c               |   2 +-
 fs/btrfs/super.c                            |   2 +-
 fs/ceph/dir.c                               |   1 +
 fs/ceph/file.c                              |   2 +-
 fs/compat_ioctl.c                           | 602 +-------------------
 fs/fat/file.c                               |  13 +-
 fs/fuse/dev.c                               |   2 +-
 fs/notify/fanotify/fanotify_user.c          |   2 +-
 fs/userfaultfd.c                            |   2 +-
 include/linux/fs.h                          |   7 +
 include/linux/if_pppox.h                    |   2 +
 include/linux/mtio.h                        |  58 ++
 include/uapi/linux/ppp-ioctl.h              |   2 +
 include/uapi/linux/ppp_defs.h               |  14 +
 net/bluetooth/hci_sock.c                    |  21 +-
 net/bluetooth/rfcomm/sock.c                 |  14 +-
 net/l2tp/l2tp_ppp.c                         |   3 +
 net/rfkill/core.c                           |   2 +-
 sound/core/oss/pcm_oss.c                    |   4 +
 sound/oss/dmasound/dmasound_core.c          |   2 +
 82 files changed, 452 insertions(+), 1034 deletions(-)
 create mode 100644 include/linux/mtio.h
Signature · 42 lines
2.20.0

Cc: "David S. Miller" <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Karsten Keil <[email protected]>
Cc: "James E.J. Bottomley" <[email protected]>
Cc: "Martin K. Petersen" <[email protected]>
Cc: Marcel Holtmann <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]