btrfs: qgroup: Prepare to deprecate unused features for btrfs_qgroup_inherit()
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest3 patches 0 repliesNew
- v13 patches 6 repliesSuperseded
Changes in v2 from the cover letter
Show more details in the 1st patch about the incompatibility for 64K page size arch.
Don't deprecate unused features right now, only mark then deprecated and output warning message for now.
Better split validation check and deprecation patches.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | btrfs: Set qgroup inherit size limit to SZ_4K instead of page sizefs/ include/ | +2 | 0 replies | |
| 2/3 | btrfs: qgroup: Validate btrfs_qgroup_inherit structure before passing it to qgroupfs/ fs/ fs/ +1 more | +48 | 0 replies | |
| 3/3 | btrfs: qgroup: Prepare to deprecate some btrfs_qgroup_inherit featuresfs/ | +11 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 0/3] btrfs: qgroup: Prepare to deprecate unused features for btrfs_qgroup_inherit()
This patchset can be fetched from github:
https://github.com/adam900710/linux/tree/qgroup_inherit_check
Which is based on v4.19-rc1 tag.
This patchset will firstly set btrfs_qgroup_inherit structure size limit from PAGE_SIZE to fixed SZ_4K.
I understand this normally will cause compatibility problem, but considering how minor this feature is and no sane guy should use it for over 100 qgroups, it should be fine in real world.
The theoretical difference can be found in the commit message of the 1st patch.
The 2nd patch introduce check function for btrfs_qgroup_inherit structure and deprecates the following features:
1) flags
No unsupported flags should sneak in.
2) num_qgroups limit
It should not exceed the maximum size of btrfs_qgroup_inherit nor the size passed from btrfs_ioctl_vol_args_v2.
3) qgroupid
No valid qgroupid should be 0/0.
The 3rd patch prepare to deprecate the following features:
1) flags
2) num_excl|ref_copies
3) btrfs_qgroup_inherit::lim
Details can be found in the 3rd patch.
changelog:
v2:
Show more details in the 1st patch about the incompatibility for 64K page size arch.
Don't deprecate unused features right now, only mark then deprecated and output warning message for now.
Better split validation check and deprecation patches.
Qu Wenruo (3):
btrfs: Set qgroup inherit size limit to SZ_4K instead of page size
btrfs: qgroup: Validate btrfs_qgroup_inherit structure before passing
it to qgroup
btrfs: qgroup: Prepare to deprecate some btrfs_qgroup_inherit features
fs/btrfs/ioctl.c | 7 +++++- fs/btrfs/qgroup.c | 44 ++++++++++++++++++++++++++++++++++++++ fs/btrfs/qgroup.h | 3 +++ include/uapi/linux/btrfs.h | 17 +++++++-------- 4 files changed, 61 insertions(+), 10 deletions(-)
Signature · 1 line
2.18.0