PCI, error handling and hot plug
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest20 patches 23 repliesIn review
- v116 patches 29 repliesSuperseded
Changes in v2 from the cover letter
* Use Dennis' patch for the incorrect slot reset detection since he posted that fix first
* I found some DPC and HPC capable ports (PLX Device 9781 to be specific) that don't have data-link active reporting capabilities, so I added another patch to handle that
* If the recovery determines the precence detection has changed during error handling, we need to prevent the downstream driver from accessing the device under its old context. This was a little tricky because of a circular dependency on the pci_bus_sem, so there is a prep patch to allow recursive pci bus walking, and then we use it from pciehp's slot_reset callback.
* Make error handling not able to change the error state away from pci_channel_state_perm_failure so that hotplug and error handling may use the same state (suggested by Benjamin Herrenschmidt)
* Moved the link active wait requirements into generic code (suggested by Sinan Kaya)
* Check for successful secondary bus reset on recovery failure (suggested by Sinan Kaya)
* Use pcie_device for service driver error callbacks (suggested by Lukas Wunner)
* Hold pci_slot_lock when doing a slot reset (suggested by Lukas Wunner)
* Fixed processing user orderly hotplug requests during error handling suggested by Lukas Wunner)
* Various code cleanups (suggested by Christoph Hellwig)
* Split dpc code cleanup into separate patch
* Changelog grammer fixes and wording clarity
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/20 | PCI: Simplify disconnected markingdrivers/ | +3 | 0 replies | |
| 2/20 | PCI: Fix faulty logic in pci_reset_bus()drivers/ | +1 | 0 replies | |
| 3/20 | PCI: Add required waits on link activedrivers/ | +18 | 2 replies | |
| 4/20 | PCI/AER: Remove dead codedrivers/ | +0 | 0 replies | |
| 5/20 | PCI/ERR: Use slot reset if availabledrivers/ drivers/ drivers/ +2 more | +38 | 0 replies | |
| 6/20 | PCI/ERR: Handle fatal error recoverydrivers/ drivers/ drivers/ +1 more | +18 | 0 replies | |
| 7/20 | PCI/ERR: Always use the first downstream portdrivers/ | +21 | 0 replies | |
| 8/20 | PCI/ERR: Simplify broadcast calloutsdrivers/ | +38 | 0 replies | |
| 9/20 | PCI/ERR: Report current recovery status for udevdrivers/ | +2 | 0 replies | |
| 10/20 | PCI/ERR: Remove devices on recovery failuredrivers/ | +38 | 0 replies | |
| 11/20 | PCI/portdrv: Provide pci error callbacksdrivers/ drivers/ | +47 | 0 replies | |
| 12/20 | PCI/portdrv: Restore pci state on slot resetdrivers/ | +2 | 0 replies | |
| 13/20 | PCI: Make link active reporting detection genericdrivers/ drivers/ drivers/ +2 more | +13 | 1 reply | |
| 14/20 | PCI: Create recursive bus walkdrivers/ include/ | +14 | 0 replies | |
| 15/20 | PCI/pciehp: Fix powerfault detection orderdrivers/ | +8 | 8 replies | |
| 16/20 | PCI/pciehp: Implement error handling callbacksdrivers/ drivers/ drivers/ | +49 | 9 replies | |
| 17/20 | PCI/pciehp: Ignore link events during DPC eventdrivers/ drivers/ include/ | +21 | 0 replies | |
| 18/20 | PCI/DPC: Wait for link active after resetdrivers/ | +4 | 0 replies | |
| 19/20 | PCI/DPC: Link reset code cleanupdrivers/ | +7 | 0 replies | |
| 20/20 | PCI: Unify device inaccessibledrivers/ drivers/ | +16 | 1 reply |
Reviews trailers per patch
3 of 20 patches have a Reviewed-by or Acked-by.
| Patch | Keith Busch | Michael J. Ruhl | Lukas Wunner |
|---|---|---|---|
| 1/20 | R-b | ||
| 2/20 | R-b | R-b | |
| 3/20 | |||
| 4/20 | |||
| 5/20 | |||
| 6/20 | |||
| 7/20 | |||
| 8/20 | |||
| 9/20 | |||
| 10/20 | |||
| 11/20 | |||
| 12/20 | |||
| 13/20 | |||
| 14/20 | |||
| 15/20 | R-b R-b | ||
| 16/20 | |||
| 17/20 | |||
| 18/20 | |||
| 19/20 | |||
| 20/20 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCHv2 00/20] PCI, error handling and hot plug
v1 -> v2:
* Use Dennis' patch for the incorrect slot reset detection since he posted that fix first
* I found some DPC and HPC capable ports (PLX Device 9781 to be specific) that don't have data-link active reporting capabilities, so I added another patch to handle that
* If the recovery determines the precence detection has changed during error handling, we need to prevent the downstream driver from accessing the device under its old context. This was a little tricky because of a circular dependency on the pci_bus_sem, so there is a prep patch to allow recursive pci bus walking, and then we use it from pciehp's slot_reset callback.
* Make error handling not able to change the error state away from pci_channel_state_perm_failure so that hotplug and error handling may use the same state (suggested by Benjamin Herrenschmidt)
* Moved the link active wait requirements into generic code (suggested by Sinan Kaya)
* Check for successful secondary bus reset on recovery failure (suggested by Sinan Kaya)
* Use pcie_device for service driver error callbacks (suggested by Lukas Wunner)
* Hold pci_slot_lock when doing a slot reset (suggested by Lukas Wunner)
* Fixed processing user orderly hotplug requests during error handling suggested by Lukas Wunner)
* Various code cleanups (suggested by Christoph Hellwig)
* Split dpc code cleanup into separate patch
* Changelog grammer fixes and wording clarity
Dennis Dalessandro (1):
PCI: Fix faulty logic in pci_reset_bus()
Keith Busch (18):
PCI: Add required waits on link active PCI/AER: Remove dead code
PCI/ERR: Use slot reset if available PCI/ERR: Handle fatal error recovery PCI/ERR: Always use the first downstream port PCI/ERR: Simplify broadcast callouts PCI/ERR: Report current recovery status for udev PCI/ERR: Remove devices on recovery failure PCI/portdrv: Provide pci error callbacks PCI/portdrv: Restore pci state on slot reset
PCI: Make link active reporting detection generic
PCI: Create recursive bus walk PCI/pciehp: Fix powerfault detection order PCI/pciehp: Implement error handling callbacks PCI/pciehp: Ignore link events during DPC event PCI/DPC: Wait for link active after reset PCI/DPC: Link reset code cleanup
PCI: Unify device inaccessible
Lukas Wunner (1):
PCI: Simplify disconnected marking
drivers/pci/bus.c | 14 +- drivers/pci/hotplug/pciehp.h | 2 +- drivers/pci/hotplug/pciehp_core.c | 39 +++++ drivers/pci/hotplug/pciehp_hpc.c | 56 +++---- drivers/pci/hotplug/pciehp_pci.c | 9 +- drivers/pci/pci.c | 68 +++++++- drivers/pci/pci.h | 17 +- drivers/pci/pcie/aer.c | 27 ++-- drivers/pci/pcie/dpc.c | 37 +++-- drivers/pci/pcie/err.c | 327 +++++++++++++------------------------- drivers/pci/pcie/portdrv.h | 10 +- drivers/pci/pcie/portdrv_pci.c | 45 +++++- drivers/pci/probe.c | 1 + drivers/pci/slot.c | 2 +- include/linux/pci.h | 10 ++ 15 files changed, 353 insertions(+), 311 deletions(-)
Signature · 1 line
2.14.4