Skip to content

Export PCIe bandwidth via sysfs

Alexandru Gagniuc intel-wired-lan linux-pci linux-rdma lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9PCI: sysfs: Export available PCIe bandwidthdrivers/pci/pci-sysfs.c+13 -06 replies
2/9bnx2x: Do not call pcie_print_link_status()drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c+0 -10 replies
3/9bnxt_en: Do not call pcie_print_link_status()drivers/net/ethernet/broadcom/bnxt/bnxt.c+0 -10 replies
4/9cxgb4: Do not call pcie_print_link_status()drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c+0 -30 replies
5/9fm10k: Do not call pcie_print_link_status()drivers/net/ethernet/intel/fm10k/fm10k_pci.c+0 -30 replies
6/9ixgbe: Do not call pcie_print_link_status()drivers/net/ethernet/intel/ixgbe/ixgbe_main.c+0 -260 replies
7/9net/mlx4: Do not call pcie_print_link_status()drivers/net/ethernet/mellanox/mlx4/main.c+0 -71 reply
8/9net/mlx5: Do not call pcie_print_link_status()drivers/net/ethernet/mellanox/mlx5/core/main.c+0 -41 reply
9/9nfp: Do not call pcie_print_link_status()drivers/net/ethernet/netronome/nfp/nfpcore/nfp6000_pcie.c+0 -10 replies

Reviews trailers per patch

2 of 9 patches have a Reviewed-by or Acked-by.

PatchLeon Romanovsky
1/9
2/9
3/9
4/9
5/9
6/9
7/9A-b
8/9A-b
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/9] Export PCIe bandwidth via sysfs

This is a follow-on series to
Commit 2d1ce5ec2117 ("PCI: Check for PCIe Link downtraining")

The remaining issues was that some pcie drivers print link status directly, sometimes resulting in duplicate system log messages with degraded links.

Quoted 1 line

From my understanding, the maintainers of these drivers are fine with

removing the duplicate prints as long as the bandwidth information is readily available. sysfs seemed to be the consensus.

Example:

	$ cat /sys/bus/pci/devices/0000:b1:00.0/available_bandwidth
	7.876 Gb/s

Alexandru Gagniuc (9):
PCI: sysfs: Export available PCIe bandwidth
bnx2x: Do not call pcie_print_link_status()
bnxt_en: Do not call pcie_print_link_status()
cxgb4: Do not call pcie_print_link_status()
fm10k: Do not call pcie_print_link_status()
ixgbe: Do not call pcie_print_link_status()
net/mlx4: Do not call pcie_print_link_status()
net/mlx5: Do not call pcie_print_link_status()
nfp: Do not call pcie_print_link_status()

 .../net/ethernet/broadcom/bnx2x/bnx2x_main.c  |  1 -
 drivers/net/ethernet/broadcom/bnxt/bnxt.c     |  1 -
 .../net/ethernet/chelsio/cxgb4/cxgb4_main.c   |  3 ---
 drivers/net/ethernet/intel/fm10k/fm10k_pci.c  |  3 ---
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 26 -------------------
 drivers/net/ethernet/mellanox/mlx4/main.c     |  7 -----
 .../net/ethernet/mellanox/mlx5/core/main.c    |  4 ---
 .../netronome/nfp/nfpcore/nfp6000_pcie.c      |  1 -
 drivers/pci/pci-sysfs.c                       | 13 ++++++++++
 9 files changed, 13 insertions(+), 46 deletions(-)
Signature · 1 line
2.17.1