qt5webkit: fix build issue using system leveldb
Get series with b4
b4 am 20180904151101.2vz46vm7q33scp4c@archlinuxVersions newest first
- v1 Latest0 of 3 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 3 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [Buildroot] [PATCH 0/3] qt5webkit: fix build issue using system leveldb
Arnout,
Quoted 7 lines · Arnout Vandecappelle
(...)
Quoted 2 lines
Note: Also, since leveldb has moved to cmake, this symbol is now a part of libleveldb.so and there is not more libmemenv.a [2] :/
So, wouldn't a bump of leveldb which moves to cmake solve the issue entirely?
First of all, the version is not yet out (1.21).
I think, the bump will partially solve that issue (not tested, but I can give it a try).
With the bump, QtWebKit would compile it as a third-party (fair but not wanted) and would link against libleveldb.so which will be provided by buildroot (1.21 with the missing symbol). In that situation, the third-party is compiled but not used and the build will succeed.
If the configure flag WEBKIT_CONFIG+=use_system_leveldb is added, QtWebKit would not compile leveldb as a third-party (wanted) but it would try to link against libraries liblevel.db (okay) *AND* libmemenv.a from buildroot's staging. But the last one will not exist and the compilation would fail.
Even with the bump, (and if the configure flag is added) QtWebKit needs to be patched to remove the -lmemenv from the compilation line; because the libmemenv will disappear.
A good fix consists in to force QtWebKit to use its third-party library (giving the full path?) so it will not link against the copy from buildroot's staging.
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
(...)
All in all, I'm just worried by the installation of what looks like some internal library/headers of leveldb. Could you comment on this ?
Quoted 6 lines
Quoted 2 lines
We can consider memenv as an option of leveldb which installs the memenv development files (static library and header).
Since it's only a static library and a header, it only gets installed to
staging, not target, so there is no reason to make it optional.
Okay, I will drop the option and respin a new version.
Quoted 4 lines
Regards,
Arnout
Quoted 9 lines
[snip]
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
Regards,
Ga?l