Skip to content

nvmem: rework of the subsystem for non-DT users

Bartosz Golaszewski linux-arm-kernel linux-doc lkml 5 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest22 patches 0 repliesNew
  2. v422 patches 2 repliesSuperseded
  3. v321 patches 3 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v216 patches26 repliesSuperseded
v113 patches5 repliesSuperseded

Changes in v5 from the cover letter

- rebased on top of char-misc-next and retested

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22nvmem: provide nvmem_dev_name()drivers/nvmem/core.c include/linux/nvmem-consumer.h+21 -00 replies
2/22nvmem: remove the name field from struct nvmem_devicedrivers/nvmem/core.c+1 -20 replies
3/22nvmem: use list_for_each_entry_safe in nvmem_device_remove_all_cells()drivers/nvmem/core.c+2 -50 replies
4/22nvmem: remove a stray newlinedrivers/nvmem/core.c+0 -10 replies
5/22nvmem: check the return value of nvmem_add_cells()drivers/nvmem/core.c+8 -20 replies
6/22nvmem: use krefdrivers/nvmem/core.c+22 -220 replies
7/22nvmem: sunxi_sid: return -ENOMEM if kzalloc() failsdrivers/nvmem/sunxi_sid.c+1 -10 replies
8/22nvmem: sunxi_sid: use devm_nvmem_register()drivers/nvmem/sunxi_sid.c+3 -170 replies
9/22nvmem: lpc18xx_eeprom: use devm_nvmem_register()drivers/nvmem/lpc18xx_eeprom.c+1 -50 replies
10/22nvmem: mxs-ocotp: use devm_nvmem_register()drivers/nvmem/mxs-ocotp.c+2 -20 replies
11/22nvmem: change the signature of nvmem_unregister()drivers/nvmem/core.c include/linux/nvmem-provider.h+5 -120 replies
12/22nvmem: remove the global cell listdrivers/nvmem/core.c+15 -490 replies
13/22nvmem: add support for cell infodrivers/nvmem/core.c include/linux/nvmem-provider.h+96 -90 replies
14/22nvmem: resolve cells from DT at registration timedrivers/nvmem/core.c+75 -480 replies
15/22nvmem: add support for cell lookups from machine codedrivers/nvmem/core.c include/linux/nvmem-consumer.h+131 -260 replies
16/22Documentation: nvmem: document cell tables and lookup entriesDocumentation/nvmem/nvmem.txt+31 -00 replies
17/22nvmem: add a notifier chaindrivers/nvmem/core.c include/linux/nvmem-consumer.h+57 -00 replies
18/22nvmem: use SPDX license identifiersdrivers/nvmem/core.c include/linux/nvmem-consumer.h include/linux/nvmem-provider.h+3 -170 replies
19/22nvmem: make the naming of arguments in nvmem_cell_get() consistentdrivers/nvmem/core.c include/linux/nvmem-consumer.h+20 -190 replies
20/22nvmem: use EOPNOTSUPP instead of ENOSYSinclude/linux/nvmem-consumer.h include/linux/nvmem-provider.h+17 -180 replies
21/22nvmem: fix commenting styledrivers/nvmem/core.c+2 -20 replies
22/22nvmem: use octal permissions instead of constantsdrivers/nvmem/core.c+4 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCH v5 00/22] nvmem: rework of the subsystem for non-DT users

From: Bartosz Golaszewski <[email protected]>

This series contains nvmem framework changes prerequisite for further development of my previous series[1] that aims at removal of the platform data struct from at24 EEPROM driver.

The patches are conceptually split into a couple groups.

First five patches fix issues with existing code.

Patch 6 switches the nvmem providers to using kref which is necessary for removal of the return value from nvmem_unregister(). This is an approach similar to the one used in the clock framework where the provider is only removed after the last reference to it is dropped.

Patch 7 changes the errno returned from the driver after kzalloc() fails from -EINVAL to -ENOMEM which makes more sense.

Patches 8-10 convert last remaining users of nvmem_unregister() who still check its return value to using devm_nvmem_unregister() and patch 11 changes its return value from int to void.

Patches 12-15 introduce the most significant changes of this series:
we remove the global cell list, add support for static cell definitions external to the provider structure, change the way DT lookup works and allow to associate resources and consumers using lookup tables. The way nvmem_cell_get() for non-DT users is changed but there are no current users and it's currently broken anyway (cell being removed after a call to nvmem_cell_put()).

Patch 16 updates the documentation.

Patch 17 adds support for notifiers to nvmem so that users can subscribe for events such as device or cell registration or removal.

Patches 18 & 19 add some minor improvements to the codebase.

Last three patches contain fixes to warnings emitted by checkpatch. It's a good moment to add them if we're already touching a big part of the subsystem's code.

Tested both DT and non-DT use cases.

[1] https://lkml.org/lkml/2018/8/10/149

v1 -> v2:
- extended the lookup structure with a proper con_id independent from the cell name defined in the cell definition table
- added a patch that makes the naming convention for the cell name argument in the nvmem_cell_get() family of functions consistent
- there were two users of nvmem_unregister() that still checked the return value, now switched to devm_nvmem_register()
- fixed build failures reported by kbuild test robot

v2 -> v3:
- dropped the patch removing unused APIs and introduced changes on top of existing code instead
- fixed nvmem provider reference decreasing in error paths
- added checkpatch fixes
- removed nvmem-machine.h and distributed new definitions among existing consumer and provider headers
- reordered patches thematically
- added more patches fixing issues in existing codebase

v3 -> v4:
- fixed the notifier chain call when removing nvmem devices: call the notifier chain for NVMEM_REMOVE before releasing any resources
- added patch 7/22 ("sunxi_sid: return -ENOMEM if kzalloc() fails")
- fixed the return value in error path for patch 8/22 ("sunxi_sid: use devm_nvmem_register())"
- fixed the return value of devm_nvmem_unregister() in patch 11/22 ("change the signature of nvmem_unregister()")

v4 -> v5:
- rebased on top of char-misc-next and retested

Bartosz Golaszewski (22):
nvmem: provide nvmem_dev_name()
nvmem: remove the name field from struct nvmem_device
nvmem: use list_for_each_entry_safe in nvmem_device_remove_all_cells()
nvmem: remove a stray newline
nvmem: check the return value of nvmem_add_cells()
nvmem: use kref
nvmem: sunxi_sid: return -ENOMEM if kzalloc() fails
nvmem: sunxi_sid: use devm_nvmem_register()
nvmem: lpc18xx_eeprom: use devm_nvmem_register()
nvmem: mxs-ocotp: use devm_nvmem_register()
nvmem: change the signature of nvmem_unregister()
nvmem: remove the global cell list
nvmem: add support for cell info
nvmem: resolve cells from DT at registration time
nvmem: add support for cell lookups from machine code
Documentation: nvmem: document cell tables and lookup entries
nvmem: add a notifier chain
nvmem: use SPDX license identifiers
nvmem: make the naming of arguments in nvmem_cell_get() consistent
nvmem: use EOPNOTSUPP instead of ENOSYS
nvmem: fix commenting style
nvmem: use octal permissions instead of constants

 Documentation/nvmem/nvmem.txt  |  31 ++
 drivers/nvmem/core.c           | 527 ++++++++++++++++++++++-----------
 drivers/nvmem/lpc18xx_eeprom.c |   6 +-
 drivers/nvmem/mxs-ocotp.c      |   4 +-
 drivers/nvmem/sunxi_sid.c      |  20 +-
 include/linux/nvmem-consumer.h | 100 +++++--
 include/linux/nvmem-provider.h |  50 ++--
 7 files changed, 497 insertions(+), 241 deletions(-)
Signature · 1 line
2.18.0