Skip to content

btrfs: trim latency improvements

[email protected] linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3btrfs: use ->devices list instead of ->alloc_list in btrfs_trim_fsfs/btrfs/extent-tree.c+2 -21 reply
2/3btrfs: don't attempt to trim devices that don't support itfs/btrfs/extent-tree.c+4 -01 reply
3/3btrfs: keep trim from interfering with transaction commitsfs/btrfs/extent-tree.c+17 -81 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchDavid Sterba
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] btrfs: trim latency improvements

From: Jeff Mahoney <[email protected]>

This patch set fixes a few issues with trim.

1) Fix device list iteration. We're iterating the ->alloc_list while holding the device_list_mutex. The ->alloc_list is protected by the chunk mutex and we don't want to hold it across the entire trim execution. Instead, use the ->devices list, which is protected by the device_list_mutex.

2) Skip trim on devices that don't support it. Rather than letting the block layer reject it, bounce out early.

3) Don't keep the commit_root_sem locked and the transaction pinned across the block layer component of trim. We only need these to ensure the pending chunks list doesn't go away underneath us, so it's safe to drop across the trim itself. Historically, this caused issues when fstrim and balance would run at the same time since balance would produce lots of transactions and would have to wait constantly, causing problems for everything else that wanted to start a transaction.

-Jeff
---

Jeff Mahoney (3):
btrfs: use ->devices list instead of ->alloc_list in btrfs_trim_fs
btrfs: don't attempt to trim devices that don't support it
btrfs: keep trim from interfering with transaction commits

 fs/btrfs/extent-tree.c | 33 +++++++++++++++++++++++----------
 1 file changed, 23 insertions(+), 10 deletions(-)
Signature · 1 line
2.12.3