Skip to content

mtd: rawnand: API cleanup (2nd batch)

Boris Brezillon linux-doc linux-mips linux-mtd linux-omap linux-sh 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest19 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19mtd: rawnand: Leave chip->IO_ADDR_{R,W} to NULL when unuseddrivers/mtd/nand/raw/brcmnand/brcmnand.c drivers/mtd/nand/raw/socrates_nand.c+0 -70 replies
2/19mtd: rawnand: Create a legacy struct and move ->IO_ADDR_{R,W} thereDocumentation/driver-api/mtdnand.rst arch/arm/mach-ep93xx/snappercl15.c arch/arm/mach-ep93xx/ts72xx.c +34 more+190 -1750 replies
3/19mtd: rawnand: Deprecate ->{read,write}_{byte,buf}() hooksdrivers/mtd/nand/raw/ams-delta.c drivers/mtd/nand/raw/atmel/nand-controller.c drivers/mtd/nand/raw/au1550nd.c +39 more+200 -2000 replies
4/19mtd: rawnand: Deprecate ->cmd_ctrl() and ->cmdfunc()drivers/mtd/nand/raw/ams-delta.c drivers/mtd/nand/raw/atmel/nand-controller.c drivers/mtd/nand/raw/au1550nd.c +44 more+144 -1370 replies
5/19mtd: rawnand: Deprecate ->dev_ready() and ->waitfunc()Documentation/driver-api/mtdnand.rst drivers/mtd/nand/raw/ams-delta.c drivers/mtd/nand/raw/atmel/nand-controller.c +39 more+93 -930 replies
6/19mtd: rawnand: Deprecate ->block_{bad,markbad}() hooksdrivers/mtd/nand/raw/cafe_nand.c drivers/mtd/nand/raw/diskonchip.c drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +5 more+40 -220 replies
7/19mtd: rawnand: Deprecate ->erase()drivers/mtd/nand/raw/denali.c drivers/mtd/nand/raw/nand_base.c include/linux/mtd/rawnand.h+8 -50 replies
8/19mtd: rawnand: Deprecate ->{set,get}_features() hooksdrivers/mtd/nand/raw/bcm47xxnflash/ops_bcm4706.c drivers/mtd/nand/raw/cafe_nand.c drivers/mtd/nand/raw/fsl_elbc_nand.c +9 more+70 -940 replies
9/19mtd: rawnand: Deprecate ->chip_delayDocumentation/driver-api/mtdnand.rst drivers/mtd/nand/raw/ams-delta.c drivers/mtd/nand/raw/atmel/nand-controller.c +36 more+53 -540 replies
10/19mtd: rawnand: Move function prototypes after struct declarationsinclude/linux/mtd/rawnand.h+12 -120 replies
11/19mtd: rawnand: Get rid of nand_flash_dev forward declationinclude/linux/mtd/rawnand.h+0 -10 replies
12/19mtd: rawnand: Get rid of the duplicate nand_chip forward declarationinclude/linux/mtd/rawnand.h+0 -30 replies
13/19mtd: rawnand: Get rid of a few unused definitionsdrivers/mtd/nand/raw/nand_timings.c include/linux/mtd/rawnand.h+0 -220 replies
14/19mtd: rawnand: Move platform_nand_xxx definitions out of rawnand.harch/arm/mach-ep93xx/snappercl15.c arch/arm/mach-ep93xx/ts72xx.c arch/arm/mach-imx/mach-qong.c +18 more+93 -950 replies
15/19mtd: rawnand: Inline onfi_get_async_timing_mode()drivers/mtd/nand/raw/nand_base.c include/linux/mtd/rawnand.h+3 -110 replies
16/19mtd: rawnand: Keep all internal stuff privatedrivers/mtd/nand/raw/internals.h drivers/mtd/nand/raw/nand_amd.c drivers/mtd/nand/raw/nand_base.c +9 more+123 -1170 replies
17/19mtd: rawnand: Move legacy code to nand_legacy.cdrivers/mtd/nand/raw/Makefile drivers/mtd/nand/raw/internals.h drivers/mtd/nand/raw/nand_base.c +1 more+660 -6080 replies
18/19mtd: rawnand: Move ONFI code to nand_onfi.cdrivers/mtd/nand/raw/Makefile drivers/mtd/nand/raw/internals.h drivers/mtd/nand/raw/nand_base.c +3 more+496 -4550 replies
19/19mtd: rawnand: Move JEDEC code to nand_jedec.cdrivers/mtd/nand/raw/Makefile drivers/mtd/nand/raw/internals.h drivers/mtd/nand/raw/nand_base.c +3 more+210 -1752 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/19] mtd: rawnand: API cleanup (2nd batch)

Hello,

This is the 2nd batch of API cleanup patches. This time we move deprecated hooks/fields to the nand_legacy struct, and then move some of the code found in nand_base.c into separate source/header files.

With this new organization, new comers should more easily identify the bits they can use in their NAND controller drivers and those that are only meant for core code. It also shrink a bit nand_base.c which was over 6000 lines of code.

Note that existing coding style issues (reported by checkpatch) in arch or driver code are intentionally not fixed to keep the series focused on the API/core cleanup.

Regards,

Boris

Boris Brezillon (19):
mtd: rawnand: Leave chip->IO_ADDR_{R,W} to NULL when unused
mtd: rawnand: Create a legacy struct and move ->IO_ADDR_{R,W} there
mtd: rawnand: Deprecate ->{read,write}_{byte,buf}() hooks
mtd: rawnand: Deprecate ->cmd_ctrl() and ->cmdfunc()
mtd: rawnand: Deprecate ->dev_ready() and ->waitfunc()
mtd: rawnand: Deprecate ->block_{bad,markbad}() hooks
mtd: rawnand: Deprecate ->erase()
mtd: rawnand: Deprecate ->{set,get}_features() hooks
mtd: rawnand: Deprecate ->chip_delay
mtd: rawnand: Move function prototypes after struct declarations
mtd: rawnand: Get rid of nand_flash_dev forward declation
mtd: rawnand: Get rid of the duplicate nand_chip forward declaration
mtd: rawnand: Get rid of a few unused definitions
mtd: rawnand: Move platform_nand_xxx definitions out of rawnand.h
mtd: rawnand: Inline onfi_get_async_timing_mode()
mtd: rawnand: Keep all internal stuff private
mtd: rawnand: Move legacy code to nand_legacy.c
mtd: rawnand: Move ONFI code to nand_onfi.c
mtd: rawnand: Move JEDEC code to nand_jedec.c

 Documentation/driver-api/mtdnand.rst             |   30 +-
 arch/arm/mach-ep93xx/snappercl15.c               |    8 +-
 arch/arm/mach-ep93xx/ts72xx.c                    |    9 +-
 arch/arm/mach-imx/mach-qong.c                    |    6 +-
 arch/arm/mach-ixp4xx/ixdp425-setup.c             |    2 +-
 arch/arm/mach-omap1/board-fsample.c              |    3 +-
 arch/arm/mach-omap1/board-h2.c                   |    3 +-
 arch/arm/mach-omap1/board-h3.c                   |    2 +-
 arch/arm/mach-omap1/board-nand.c                 |    2 +-
 arch/arm/mach-omap1/board-perseus2.c             |    3 +-
 arch/arm/mach-orion5x/ts78xx-setup.c             |    9 +-
 arch/arm/mach-pxa/balloon3.c                     |    5 +-
 arch/arm/mach-pxa/em-x270.c                      |    9 +-
 arch/arm/mach-pxa/palmtx.c                       |    5 +-
 arch/mips/alchemy/devboards/db1200.c             |    9 +-
 arch/mips/alchemy/devboards/db1300.c             |    9 +-
 arch/mips/alchemy/devboards/db1550.c             |    9 +-
 arch/mips/netlogic/xlr/platform-flash.c          |    3 +-
 arch/mips/pnx833x/common/platform.c              |    5 +-
 arch/mips/rb532/devices.c                        |    5 +-
 arch/sh/boards/mach-migor/setup.c                |    8 +-
 drivers/mtd/nand/raw/Makefile                    |    4 +-
 drivers/mtd/nand/raw/ams-delta.c                 |   22 +-
 drivers/mtd/nand/raw/atmel/nand-controller.c     |   22 +-
 drivers/mtd/nand/raw/au1550nd.c                  |   43 +-
 drivers/mtd/nand/raw/bcm47xxnflash/ops_bcm4706.c |   22 +-
 drivers/mtd/nand/raw/brcmnand/brcmnand.c         |   15 +-
 drivers/mtd/nand/raw/cafe_nand.c                 |   22 +-
 drivers/mtd/nand/raw/cmx270_nand.c               |   28 +-
 drivers/mtd/nand/raw/cs553x_nand.c               |   42 +-
 drivers/mtd/nand/raw/davinci_nand.c              |   34 +-
 drivers/mtd/nand/raw/denali.c                    |   23 +-
 drivers/mtd/nand/raw/diskonchip.c                |   50 +-
 drivers/mtd/nand/raw/fsl_elbc_nand.c             |   18 +-
 drivers/mtd/nand/raw/fsl_ifc_nand.c              |   24 +-
 drivers/mtd/nand/raw/fsl_upm.c                   |   30 +-
 drivers/mtd/nand/raw/fsmc_nand.c                 |    1 -
 drivers/mtd/nand/raw/gpio.c                      |   16 +-
 drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c       |   22 +-
 drivers/mtd/nand/raw/hisi504_nand.c              |   18 +-
 drivers/mtd/nand/raw/internals.h                 |  114 ++
 drivers/mtd/nand/raw/jz4740_nand.c               |   14 +-
 drivers/mtd/nand/raw/jz4780_nand.c               |   10 +-
 drivers/mtd/nand/raw/lpc32xx_mlc.c               |   12 +-
 drivers/mtd/nand/raw/lpc32xx_slc.c               |   26 +-
 drivers/mtd/nand/raw/mpc5121_nfc.c               |   14 +-
 drivers/mtd/nand/raw/mtk_nand.c                  |   12 +-
 drivers/mtd/nand/raw/mxc_nand.c                  |   20 +-
 drivers/mtd/nand/raw/nand_amd.c                  |    2 +-
 drivers/mtd/nand/raw/nand_base.c                 | 1260 +++-------------------
 drivers/mtd/nand/raw/nand_bbt.c                  |    5 +-
 drivers/mtd/nand/raw/nand_hynix.c                |    9 +-
 drivers/mtd/nand/raw/nand_ids.c                  |    4 +-
 drivers/mtd/nand/raw/nand_jedec.c                |  113 ++
 drivers/mtd/nand/raw/nand_legacy.c               |  642 +++++++++++
 drivers/mtd/nand/raw/nand_macronix.c             |    2 +-
 drivers/mtd/nand/raw/nand_micron.c               |    3 +-
 drivers/mtd/nand/raw/nand_onfi.c                 |  305 ++++++
 drivers/mtd/nand/raw/nand_samsung.c              |    2 +-
 drivers/mtd/nand/raw/nand_timings.c              |   18 +-
 drivers/mtd/nand/raw/nand_toshiba.c              |    2 +-
 drivers/mtd/nand/raw/nandsim.c                   |   14 +-
 drivers/mtd/nand/raw/ndfc.c                      |   14 +-
 drivers/mtd/nand/raw/nuc900_nand.c               |   22 +-
 drivers/mtd/nand/raw/omap2.c                     |   62 +-
 drivers/mtd/nand/raw/orion_nand.c                |   12 +-
 drivers/mtd/nand/raw/oxnas_nand.c                |   10 +-
 drivers/mtd/nand/raw/pasemi_nand.c               |   32 +-
 drivers/mtd/nand/raw/plat_nand.c                 |   17 +-
 drivers/mtd/nand/raw/qcom_nandc.c                |   39 +-
 drivers/mtd/nand/raw/r852.c                      |   14 +-
 drivers/mtd/nand/raw/s3c2410.c                   |   34 +-
 drivers/mtd/nand/raw/sh_flctl.c                  |   18 +-
 drivers/mtd/nand/raw/sharpsl.c                   |   12 +-
 drivers/mtd/nand/raw/sm_common.c                 |    2 +-
 drivers/mtd/nand/raw/socrates_nand.c             |   16 +-
 drivers/mtd/nand/raw/sunxi_nand.c                |   14 +-
 drivers/mtd/nand/raw/tango_nand.c                |   12 +-
 drivers/mtd/nand/raw/tmio_nand.c                 |   20 +-
 drivers/mtd/nand/raw/txx9ndfmc.c                 |   12 +-
 drivers/mtd/nand/raw/xway_nand.c                 |   12 +-
 drivers/staging/mt29f_spinand/mt29f_spinand.c    |   16 +-
 include/linux/mtd/jedec.h                        |   91 ++
 include/linux/mtd/onfi.h                         |  178 +++
 include/linux/mtd/platnand.h                     |   74 ++
 include/linux/mtd/rawnand.h                      |  555 ++--------
 86 files changed, 2300 insertions(+), 2191 deletions(-)
 create mode 100644 drivers/mtd/nand/raw/internals.h
 create mode 100644 drivers/mtd/nand/raw/nand_jedec.c
 create mode 100644 drivers/mtd/nand/raw/nand_legacy.c
 create mode 100644 drivers/mtd/nand/raw/nand_onfi.c
 create mode 100644 include/linux/mtd/jedec.h
 create mode 100644 include/linux/mtd/onfi.h
 create mode 100644 include/linux/mtd/platnand.h
Signature · 1 line
2.14.1