Skip to content

btrfs: trim enhancement to allow btrfs really trim block groups

Qu Wenruo linux-btrfs stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

v2 from the cover letter

Only report total number of errors and first errno to make it less noisy.
Change message level from warning to debug

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2btrfs: Enhance btrfs_trim_fs function to handle error betterfs/btrfs/extent-tree.c+39 -162 replies
2/2btrfs: Ensure btrfs_trim_fs can trim the whole fsfs/btrfs/extent-tree.c fs/btrfs/ioctl.c+8 -131 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchDavid Sterba
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH v3.1 0/2] btrfs: trim enhancement to allow btrfs really trim block groups

This patchset can be fetched from github:
https://github.com/adam900710/linux/tree/trim_fix
Which is based on v4.19-rc1 tag.

This patchset introduces 2 enhancement, one to output better error messages during trim, the other one is to ensure we could really trim block groups if logical bytenr of block groups are beyond physical device size.

These two patches are in the wild for a long time, and are pretty small and the 2nd patch in facts fix a regression, and we already have test case for it (btrfs/156).

Changelog:
v2:
Only report total number of errors and first errno to make it less noisy.
Change message level from warning to debug
v3:
Rebase to v4.19-rc1.
Change back message level from debug to warning since it's less noisy and will only report total failed bgs and devices.

v3.1
Remove the "last error" output from first patch.

Qu Wenruo (2):
btrfs: Enhance btrfs_trim_fs function to handle error better
btrfs: Ensure btrfs_trim_fs can trim the whole fs

 fs/btrfs/extent-tree.c | 65 ++++++++++++++++++++++++++----------------
 fs/btrfs/ioctl.c       | 11 ++++---
 2 files changed, 47 insertions(+), 29 deletions(-)
Signature · 1 line
2.18.0