Skip to content

add quartz load support to NXP rtc drivers

Sam Ravnborg linux-devicetree linux-rtc lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 3 repliesIn review
  2. v25 patches 6 repliesSuperseded
  3. v15 patches 11 repliesSuperseded

Changes in v3 from the cover letter

- Document generic property "quartz-load-femtofarads" in rtc.txt (Rob)
- Fix indent several places - ups (Alexandre)
- Use the simpler name "rtc" in DT examples (Rob)
- Collected "Reviewed by's"

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6devicetree: property-units: Add femtofarads unitDocumentation/devicetree/bindings/property-units.txt+1 -00 replies
2/6dt-bindings: rtc: Add quartz-load-femtofarads propertyDocumentation/devicetree/bindings/rtc/rtc.txt+10 -61 reply
3/6dt-binding: pcf8523: add xtal load capacitanceDocumentation/devicetree/bindings/rtc/nxp,pcf8523.txt Documentation/devicetree/bindings/rtc/rtc.txt+18 -10 replies
4/6dt-binding: pcf85063: add xtal load capacitanceDocumentation/devicetree/bindings/rtc/nxp,pcf85063.txt Documentation/devicetree/bindings/rtc/rtc.txt+18 -11 reply
5/6rtc: pcf8523: set xtal load capacitance from DTdrivers/rtc/rtc-pcf8523.c+20 -80 replies
6/6rtc: pcf85063: set xtal load capacitance from DTdrivers/rtc/rtc-pcf85063.c+39 -00 replies

Reviews trailers per patch

4 of 6 patches have a Reviewed-by or Acked-by.

PatchRob Herring
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/6] add quartz load support to NXP rtc drivers

Respin of patchset on top of v5.0-rc2 with feedback addressed (thanks!)

Introduce a new generic property "quartz-load-femtofarad" to specify the quartz load.
The default value is selected to match the current Linux drivers, so there are no behavior changes if a binding do not specify the quarts-load.
The unit is femtofarads because several RTC's define the quarts load in steps of 0.5 pF.

The two drivers rtc-pcf8523 and rtc-pcf85063 are both updated to use the new binding.
Previously pcf8523 hardcoded the quartz load to 12.5pF, and pcf85063 used the reset default of 7pF.
With this patchset it can now be specified in the DT, if the defaults are not OK.

The patch-set is tested on a proprietary board for both
RTC variants (v2 variant only as there was only trivial changes in v3).

Sam

v3:
- Document generic property "quartz-load-femtofarads" in rtc.txt (Rob)
- Fix indent several places - ups (Alexandre)
- Use the simpler name "rtc" in DT examples (Rob)
- Collected "Reviewed by's"

v2:
- Introduce a generic property "quartz-load-femtofarads"
- Add femtofarads to property-units.txt
- Make the changes backward compatible
- Reduced logging
- Warn, when we continue with a default value
- Tested, by Søren Andersen, on real HW
- Rebased on top of v5.0-rc1

Sam

Sam Ravnborg (6):
devicetree: property-units: Add femtofarads unit
dt-bindings: rtc: Add quartz-load-femtofarads property
dt-binding: pcf8523: add xtal load capacitance
dt-binding: pcf85063: add xtal load capacitance
rtc: pcf8523: set xtal load capacitance from DT
rtc: pcf85063: set xtal load capacitance from DT

 .../devicetree/bindings/property-units.txt         |  1 +
 .../devicetree/bindings/rtc/nxp,pcf85063.txt       | 18 ++++++++++
 .../devicetree/bindings/rtc/nxp,pcf8523.txt        | 18 ++++++++++
 Documentation/devicetree/bindings/rtc/rtc.txt      | 18 +++++-----
 drivers/rtc/rtc-pcf85063.c                         | 39 ++++++++++++++++++++++
 drivers/rtc/rtc-pcf8523.c                          | 28 +++++++++++-----
 6 files changed, 106 insertions(+), 16 deletions(-)