Don't pass flags to bdrv_reopen_queue()
Status from this message: Thanks, applied patch 16 to block and the rest of the series to
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest16 patches 5 repliesApplied
- v415 patches 8 repliesSuperseded
- v315 patches 0 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 14 patches | 0 replies | Superseded | |
| v1 | 1 patch | 0 replies | Superseded |
Changes in v5 from the cover letter
- Patch 14: Update commit message and add test for auto-read-only [Max]
- Patch 16: Fix update of BDRV_O_AUTO_RDONLY [Max]
Patches in v5 Applied
Reviews trailers per patch
15 of 16 patches have a Reviewed-by or Acked-by.
| Patch | Max Reitz |
|---|---|
| 1/16 | R-b |
| 2/16 | R-b |
| 3/16 | R-b |
| 4/16 | R-b |
| 5/16 | R-b |
| 6/16 | R-b |
| 7/16 | R-b |
| 8/16 | R-b |
| 9/16 | R-b |
| 10/16 | R-b |
| 11/16 | R-b |
| 12/16 | R-b |
| 13/16 | R-b |
| 14/16 | R-b |
| 15/16 | R-b |
| 16/16 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v5 00/16] Don't pass flags to bdrv_reopen_queue()
Hi all,
when reopening a BlockDriverState using bdrv_reopen() and friends the new options can be specified either with a QDict or with flags. Both methods overlap and that makes the semantics and the implementation unnecessarily complicated.
This series removes the 'flags' parameter from these functions, so from now on all option changes must be specified using a QDict. Apart from simplifying the API, a few bugs are fixed along the way. See the individual patches for more details.
This was tested with the current master (460f0236c12a86a38692c12d9bf).
Regards,
Berto
v5:
- Patch 14: Update commit message and add test for auto-read-only [Max]
- Patch 16: Fix update of BDRV_O_AUTO_RDONLY [Max]
v4: https://lists.gnu.org/archive/html/qemu-block/2018-11/msg00228.html
- Patch 14: Don't assert if BDRV_OPT_AUTO_READ_ONLY is missing, e.g. qemu-io -c 'reopen -o auto-read-only=foo' -f raw null-co://
v3: https://lists.gnu.org/archive/html/qemu-block/2018-10/msg00648.html
- Patch 1 [from v2] has been removed and all other patch numbers are shifted.
- Patches 10 and 13: Fixed rebase conflicts after the patch removal.
- Patch 14: Replacement for the removed patch using a different approach.
- Patch 15: Document a non-obvious call to update_flags_from_options()
v2: https://lists.gnu.org/archive/html/qemu-block/2018-10/msg00534.html
- Patches 4 and 9: Fixed trivial rebase conflict
- Patch 11: Update messages [Max]
- Patch 12: Add comment and use bdrv_is_read_only() instead of using the flags directly [Max]
- Patch 14: Remove inner block and move all variable declarations to the beginning of the function [Max]
v1: https://lists.gnu.org/archive/html/qemu-block/2018-09/msg00483.html
- Initial version
Output of backport-diff against v4:
Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively
001/16:[----] [--] 'block: Add bdrv_reopen_set_read_only()'
002/16:[----] [--] 'block: Use bdrv_reopen_set_read_only() in bdrv_backing_update_filename()' 003/16:[----] [--] 'block: Use bdrv_reopen_set_read_only() in commit_start/complete()' 004/16:[----] [--] 'block: Use bdrv_reopen_set_read_only() in bdrv_commit()' 005/16:[----] [--] 'block: Use bdrv_reopen_set_read_only() in stream_start/complete()' 006/16:[----] [--] 'block: Use bdrv_reopen_set_read_only() in qmp_change_backing_file()' 007/16:[----] [--] 'block: Use bdrv_reopen_set_read_only() in external_snapshot_commit()' 008/16:[----] [--] 'block: Use bdrv_reopen_set_read_only() in the mirror driver' 009/16:[----] [--] 'block: Drop bdrv_reopen()'
010/16:[----] [--] 'qemu-io: Put flag changes in the options QDict in reopen_f()' 011/16:[----] [--] 'block: Clean up reopen_backing_file() in block/replication.c' 012/16:[----] [--] 'block: Remove flags parameter from bdrv_reopen_queue()' 013/16:[----] [--] 'block: Stop passing flags to bdrv_reopen_queue_child()' 014/16:[0002] [FC] 'block: Remove assertions from update_flags_from_options()' 015/16:[----] [--] 'block: Assert that flags are up-to-date in bdrv_reopen_prepare()' 016/16:[down] 'block: Fix update of BDRV_O_AUTO_RDONLY in update_flags_from_options()'
Alberto Garcia (16):
block: Add bdrv_reopen_set_read_only()
block: Use bdrv_reopen_set_read_only() in
bdrv_backing_update_filename()
block: Use bdrv_reopen_set_read_only() in commit_start/complete()
block: Use bdrv_reopen_set_read_only() in bdrv_commit()
block: Use bdrv_reopen_set_read_only() in stream_start/complete()
block: Use bdrv_reopen_set_read_only() in qmp_change_backing_file()
block: Use bdrv_reopen_set_read_only() in external_snapshot_commit()
block: Use bdrv_reopen_set_read_only() in the mirror driver
block: Drop bdrv_reopen()
qemu-io: Put flag changes in the options QDict in reopen_f()
block: Clean up reopen_backing_file() in block/replication.c
block: Remove flags parameter from bdrv_reopen_queue()
block: Stop passing flags to bdrv_reopen_queue_child()
block: Remove assertions from update_flags_from_options()
block: Assert that flags are up-to-date in bdrv_reopen_prepare()
block: Fix update of BDRV_O_AUTO_RDONLY in update_flags_from_options()
block.c | 93 ++++++++++++++++++++-------------------------- block/commit.c | 23 +++++------- block/mirror.c | 19 ++++++---- block/replication.c | 43 ++++++++++----------- block/stream.c | 20 +++++----- blockdev.c | 11 ++---- include/block/block.h | 6 +-- qemu-io-cmds.c | 29 ++++++++++++++- tests/qemu-iotests/133 | 18 +++++++++ tests/qemu-iotests/133.out | 15 ++++++++ 10 files changed, 156 insertions(+), 121 deletions(-)
Signature · 1 line
2.11.0