Skip to content

RFC Flow sorted receive skb lists

Steffen Klassert netdev 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2net: Support flow sorted RX skb lists for IPv4.include/linux/skbuff.h net/core/dev.c net/core/flow_dissector.c +3 more+270 -140 replies
2/2net: Hack to enable skb list receive in the napi layer.include/linux/netdevice.h net/core/dev.c net/ipv4/ip_input.c+19 -100 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH RFC 0/2] Flow sorted receive skb lists

This patchset consists of two patches. Patch 1 adds support for flow sorted rx skb lists for IPv4. This means that it sorts the skb list so that packets from the same flow can to travel together through the stack.

The second patch of this pachset is just a hack that disables GRO and does skb list receive instead. I don't have a NIC whose driver supports to build skb lists to be received by netif_receive_skb_list(), so I used this hack to test patch 1.

This is early stage work, so it might be not complete and still buggy. I send this now because I want to hear some comments on the approach itself before I spend more time to work on this.

Forwarding performance measurements:

I used used my IPsec forwarding test setup for this:

           ------------         ------------
        -->| router 1 |-------->| router 2 |--
        |  ------------         ------------  |
        |                                     |
        |       --------------------          |
        --------|Spirent Testcenter|<----------
                --------------------

net-next (September 6th):

Single stream UDP frame size 1460 Bytes: 1.258.446 fps.

Single stream UDP frame size 64 Bytes: 1.250.000 fps.

----------------------------------------------------------------------

net-next (September 6th) + patch 2 (list receive):

Single stream UDP frame size 1460 Bytes: 1.469.595 fps (+16%).

Single stream UDP frame size 64 Bytes: 1.502.976 fps (+20%).

----------------------------------------------------------------------

net-next (September 6th) + patch 1 + patch 2 (flow sorted list receive):

Single stream UDP frame size 1460 Bytes: 2.525.338 fps (+100%).

Single stream UDP frame size 64 Bytes: 2.541.881 fps (+103%).

-----------------------------------------------------------------------