Skip to content

Enhanced error messages for btrfs-convert

Qu Wenruo linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2btrfs: convert: Make read_disk_extent() return more meaningful -EIO other -1convert/source-fs.c+1 -11 reply
2/2btrfs-progs: convert: Output meaningful error messages for create_image()convert/main.c+30 -71 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchNikolay Borisov
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] Enhanced error messages for btrfs-convert

This patchset can be fetched from github:
https://github.com/adam900710/btrfs-progs/tree/convert_error_messages
As usual, it's based on latest stable tag (v4.17.1).

There is one error report of btrfs-convert, the error message looks pretty meaningless:

create btrfs filesystem:

      blocksize: 4096
      nodesize:  16384
      features:  extref, skinny-metadata (default)

creating ext2 image file
ERROR: failed to create ext2_saved/image: -1
WARNING: an error occurred during conversion, filesystem is partially created but not finalized and not mountable

After some investigation, the problem turns out to be read failure. But the error number is intermediate number (-1) returned from read_disk_extent().

This patchset will first fix the intermediate return number of read_disk_extent(), then add more error messages for btrfs-convert (at least convert part) to makes it easier to identify the problem.

In this particular case, it should output things like:

create btrfs filesystem:

      blocksize: 4096
      nodesize:  16384
      features:  extref, skinny-metadata (default)

creating ext2 image file
ERROR: failed to calculate csum for bytenr 2732765184 len 4096, Input/output error
ERROR: failed to create ext2_saved/image: -5
WARNING: an error occurred during conversion, filesystem is partially created but not finalized and not mountable

Qu Wenruo (2):
btrfs: convert: Make read_disk_extent() return more meaningful -EIO
other -1
btrfs-progs: convert: Output meaningful error messages for
create_image()

 convert/main.c      | 37 ++++++++++++++++++++++++++++++-------
 convert/source-fs.c |  2 +-
 2 files changed, 31 insertions(+), 8 deletions(-)
Signature · 1 line
2.19.0