Skip to content

Make ABORT and LUN RESET handling synchronous

Bart Van Assche stable target-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest17 patches 24 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17target/core: Fix spelling in two source code commentsdrivers/target/target_core_transport.c+2 -20 replies
2/17target/core: Use the SECTOR_SHIFT constantdrivers/target/target_core_iblock.c drivers/target/target_core_iblock.h+2 -30 replies
3/17target/core: Remove an unused data member from struct xcopy_pt_cmddrivers/target/target_core_xcopy.c+0 -30 replies
4/17target/core: Change the return type of transport_init_session from void to intdrivers/target/target_core_transport.c drivers/target/target_core_xcopy.c include/target/target_core_fabric.h+14 -40 replies
5/17target/core: Make sure that target_wait_for_sess_cmds() waits long enoughdrivers/target/target_core_transport.c include/target/target_core_base.h+19 -94 replies
6/17target/core: Use sg_alloc_table() instead of open-coding itdrivers/target/target_core_sbc.c+5 -64 replies
7/17target/core: Use system workqueues for TMFdrivers/target/target_core_device.c drivers/target/target_core_transport.c include/target/target_core_base.h+1 -183 replies
8/17target/core: Make compare_and_write_callback() accept NULL as third argumentdrivers/target/target_core_sbc.c+2 -13 replies
9/17target/core: Always call transport_complete_callback() upon failuredrivers/target/target_core_sbc.c drivers/target/target_core_transport.c+8 -92 replies
10/17target/core: Make it possible to wait from more than one context for command completiodrivers/target/target_core_transport.c include/target/target_core_base.h+60 -112 replies
11/17target/core: Make ABORT and LUN RESET handling synchronousdrivers/target/target_core_internal.h drivers/target/target_core_tmr.c drivers/target/target_core_transport.c +2 more+153 -2040 replies
12/17target/core: Reduce the amount of code executed with a spinlock helddrivers/target/target_core_transport.c+3 -60 replies
13/17target/core: Avoid that LUN reset sporadically triggers data corruptiondrivers/target/target_core_tmr.c+5 -40 replies
14/17target/qla2xxx: Simplify the code for handling aborted commandsdrivers/scsi/qla2xxx/tcm_qla2xxx.c+5 -213 replies
15/17target/core: Remove the write_pending_status() callback functionDocumentation/target/tcm_mod_builder.py drivers/infiniband/ulp/srpt/ib_srpt.c drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c +13 more+0 -1040 replies
16/17target/core: Remove several state tests from the TMF codedrivers/target/target_core_tmr.c drivers/target/target_core_transport.c include/target/target_core_base.h+0 -280 replies
17/17target/core: Simplify the LUN RESET implementationdrivers/target/target_core_tmr.c+2 -120 replies

Reviews trailers per patch

5 of 17 patches have a Reviewed-by or Acked-by.

PatchFelipe BalbiSagi GrimbergAndy GroverChristoph HellwigHannes ReineckeBryant G. LyNicholas BellingerHimanshu Madhani
1/17
2/17
3/17
4/17
5/17
6/17
7/17R-b
8/17
9/17R-b R-b
10/17
11/17
12/17
13/17
14/17A-b
15/17A-b R-b R-b R-b R-b R-b
16/17
17/17R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 8 reviewers.

Read the v1 thread

Cover letter [PATCH 00/17] Make ABORT and LUN RESET handling synchronous

Hello Martin,

As you maybe know the LIO task management handling code is complicated because it is asynchronous compared to the command execution flow. This patch series makes task management function handling synchronous and thereby significantly simplifies the LIO code. Please consider these patches for kernel v4.20.

Thanks,

Bart.

Bart Van Assche (17):
target/core: Fix spelling in two source code comments target/core: Use the SECTOR_SHIFT constant
target/core: Remove an unused data member from struct xcopy_pt_cmd target/core: Change the return type of transport_init_session from
void to int
target/core: Make sure that target_wait_for_sess_cmds() waits long
enough
target/core: Use sg_alloc_table() instead of open-coding it target/core: Use system workqueues for TMF
target/core: Make compare_and_write_callback() accept NULL as third
argument
target/core: Always call transport_complete_callback() upon failure target/core: Make it possible to wait from more than one context for
command completion
target/core: Make ABORT and LUN RESET handling synchronous target/core: Reduce the amount of code executed with a spinlock held target/core: Avoid that LUN reset sporadically triggers data
corruption
target/qla2xxx: Simplify the code for handling aborted commands target/core: Remove the write_pending_status() callback function target/core: Remove several state tests from the TMF code target/core: Simplify the LUN RESET implementation

 Documentation/target/tcm_mod_builder.py      |   8 -
 drivers/infiniband/ulp/srpt/ib_srpt.c        |   9 -
 drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c     |   6 -
 drivers/scsi/qla2xxx/tcm_qla2xxx.c           |  31 --
 drivers/target/iscsi/iscsi_target_configfs.c |  13 -
 drivers/target/loopback/tcm_loop.c           |   6 -
 drivers/target/sbp/sbp_target.c              |   6 -
 drivers/target/target_core_configfs.c        |   4 -
 drivers/target/target_core_device.c          |  16 -
 drivers/target/target_core_iblock.c          |   4 +-
 drivers/target/target_core_iblock.h          |   1 -
 drivers/target/target_core_internal.h        |   2 -
 drivers/target/target_core_sbc.c             |  20 +-
 drivers/target/target_core_tmr.c             |  97 ++---
 drivers/target/target_core_transport.c       | 430 +++++++++----------
 drivers/target/target_core_xcopy.c           |  15 +-
 drivers/target/tcm_fc/tcm_fc.h               |   1 -
 drivers/target/tcm_fc/tfc_cmd.c              |   7 -
 drivers/target/tcm_fc/tfc_conf.c             |   1 -
 drivers/usb/gadget/function/f_tcm.c          |   9 -
 drivers/vhost/scsi.c                         |   6 -
 drivers/xen/xen-scsiback.c                   |   6 -
 include/target/target_core_base.h            |   6 +-
 include/target/target_core_fabric.h          |   4 +-
 24 files changed, 272 insertions(+), 436 deletions(-)
Signature · 1 line
2.18.0