Skip to content

blk-mq: allow to unfreeze queue when io isn't drained

Ming Lei linux-block linux-nvme lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3lib/percpu-refcount: introduce percpu_ref_resurge()include/linux/percpu-refcount.h lib/percpu-refcount.c+53 -110 replies
2/3blk-mq: introduce blk_mq_unfreeze_queue_no_drain_ioblock/blk-mq.c include/linux/blk-mq.h+24 -20 replies
3/3nvme: don't drain IO in nvme_reset_work()drivers/nvme/host/core.c drivers/nvme/host/nvme.h drivers/nvme/host/pci.c+10 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] blk-mq: allow to unfreeze queue when io isn't drained

Hi,

The 1st patch introduces percpu_ref_resurge() for implementing blk_mq_unfreeze_queue_no_drain_io().

The 2nd patch introdces blk_mq_unfreeze_queue_no_drain_io() for cases in which queue can be unfreeze without draininig IO.

The 3rd patch applies blk_mq_unfreeze_queue_no_drain_io() to NVMe PCI timeout, so that IO hang may be avoided inside nvme_reset_work() when new IO timeout is triggered.

Part of idea is from Jianchao's early work:

https://marc.info/?l=linux-kernel&m=153612052611020&w=2

Ming Lei (3):
lib/percpu-refcount: introduce percpu_ref_resurge()
blk-mq: introduce blk_mq_unfreeze_queue_no_drain_io
nvme: don't drain IO in nvme_reset_work()

 block/blk-mq.c                  | 25 ++++++++++++++--
 drivers/nvme/host/core.c        | 12 +++++---
 drivers/nvme/host/nvme.h        |  2 +-
 drivers/nvme/host/pci.c         |  3 +-
 include/linux/blk-mq.h          |  1 +
 include/linux/percpu-refcount.h |  1 +
 lib/percpu-refcount.c           | 63 ++++++++++++++++++++++++++++++++++-------
 7 files changed, 87 insertions(+), 20 deletions(-)
Cc Tejun Heo <tj at kernel.org>
Cc Jianchao Wang <jianchao.w.wang at oracle.com>
Cc Kent Overstreet <kent.overstreet at gmail.com>
Cc linux-block at vger.kernel.org
Cc Christoph Hellwig <hch at lst.de>
Cc linux-nvme at lists.infradead.org
Cc Keith Busch <keith.busch at intel.com>
Signature · 1 line
2.9.5