Skip to content

Assorted overlayfs fixes for 4.19-rc5

Amir Goldstein linux-fsdevel linux-unionfs stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4ovl: fix memory leak on unlink of indexed filefs/overlayfs/util.c+2 -12 replies
2/4ovl: fix freeze protection bypass in ovl_write_iter()fs/overlayfs/file.c+2 -00 replies
3/4ovl: fix freeze protection bypass in ovl_clone_file_range()fs/overlayfs/file.c+1 -10 replies
4/4vfs: swap names of {do,vfs}_clone_file_range()fs/ioctl.c fs/nfsd/vfs.c fs/overlayfs/copy_up.c +3 more+23 -200 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] Assorted overlayfs fixes for 4.19-rc5

Miklos,

Found one memory leak that needs a fix for stable and two missing freeze protections in stacked f_ops.

Last patch is not a bugfix, but it fixes a trap that we set for developers back in v4.10 - and you happened to step into.

The series passed xfstests -g quick with overlayfs over xfs and ext4 and the usual unionmount testsuite torture.

The memory leak was detected with tests overlay/051,053 after I enabled kmemleak on my test setup.

Thanks,
Amir.

Amir Goldstein (4):
ovl: fix memory leak on unlink of indexed file
ovl: fix freeze protection bypass in ovl_write_iter()
ovl: fix freeze protection bypass in ovl_clone_file_range()
vfs: swap names of {do,vfs}_clone_file_range()

 fs/ioctl.c             |  2 +-
 fs/nfsd/vfs.c          |  3 ++-
 fs/overlayfs/copy_up.c |  2 +-
 fs/overlayfs/file.c    |  2 ++
 fs/overlayfs/util.c    |  3 ++-
 fs/read_write.c        | 17 +++++++++++++++--
 include/linux/fs.h     | 17 +++--------------
 7 files changed, 26 insertions(+), 20 deletions(-)
Signature · 1 line
2.17.1