macsec: reflect the master interface state
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest1 patch 4 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/1 | macsec: reflect the master interface statedrivers/ | +46 | 4 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/1] macsec: reflect the master interface state
Hi everyone,
I came across an issue with macsec interfaces where they don't reflect the master interface state. On one hand you cannot set the macsec interface link state to up unless the master interface is already up, but on the other hand, if the master interface goes down while the macsec interface is already up, the macsec interface stays up.
This may also be problematic if macsec interfaces are used as bridge ports (probably not very usual, but that is my use case anyway). In that case the bridge has no idea of the link state of the real device, since it only sees the macsec interface, which is always up.
I'm proposing the attached patch, which is heavily inspired from the vlan (802.1q) driver. However, in the case of macsec, there is no concept of "loose binding" and the state is always reflected.
I tested the patch on x86_64, but I guess it's pretty much architecture independent.
Any comments or suggestions are welcome. Thanks!
Radu Rendec (1):
macsec: reflect the master interface state
drivers/net/macsec.c | 57 +++++++++++++++++++++++++++++++++++--------- 1 file changed, 46 insertions(+), 11 deletions(-)
Signature · 1 line
2.17.1