Skip to content

ARM: qcom: add vibrator support for various MSM SOCs

Brian Masney linux-arm-msm linux-devicetree linux-input lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 3 repliesIn review
  2. v33 patches 4 repliesSuperseded
  3. v23 patches 2 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v13 patches2 repliesSuperseded

Changes in v4 from the cover letter

- Patch 2 is the only one that changed based on feedback from Dmitry Torokhov. See notes on that patch for details.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3dt-bindings: Input: new bindings for MSM vibratorDocumentation/devicetree/bindings/input/msm-vibrator.txt+36 -00 replies
2/3Input: add new vibrator driver for various MSM SOCsdrivers/input/misc/Kconfig drivers/input/misc/Makefile drivers/input/misc/msm-vibrator.c+293 -01 reply
3/3ARM: dts: qcom: msm8974-hammerhead: add device tree bindings for vibratorarch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts+31 -02 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchRob Herring
1/3R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/3] ARM: qcom: add vibrator support for various MSM SOCs

This patch set adds support for the vibrator found on various Qualcomm MSM SOCs. This is based on work from:

Jonathan Marek from qcom,pwm-vibrator.c in the PostmarketOS repo:
https://gitlab.com/postmarketOS/linux-postmarketos/commit/7647fb36cb1cbd060f8b52087a68ab93583292b5

Jongrak Kwon and Devin Kim from msm_pwm_vibrator.c in the downstream Android 3.4.0 sources:
https://android.googlesource.com/kernel/msm/+/android-msm-lenok-3.10-lollipop-wear-release/drivers/misc/msm_pwm_vibrator.c

Driver was tested on a LG Nexus 5 (hammerhead) phone using rumble-test:
https://git.collabora.com/cgit/user/sre/rumble-test.git/plain/rumble-test.c

Changes since v3
- Patch 2 is the only one that changed based on feedback from Dmitry Torokhov. See notes on that patch for details.

Changes since v2
- Moved from pwm to input subsystem based on feedback from
https://lore.kernel.org/lkml/20181012114749.GC31561@ulmo/. I previously wired this into the input system via pwm-vibra.

Changes since v1
- Update device tree binding document based on feedback from Rob Herring.
- Changed the driver description to: Qualcomm PWM driver for the MSM vibrator.

Brian Masney (3):
dt-bindings: Input: new bindings for MSM vibrator
Input: add new vibrator driver for various MSM SOCs
ARM: dts: qcom: msm8974-hammerhead: add device tree bindings for
vibrator

 .../bindings/input/msm-vibrator.txt           |  36 +++
 .../qcom-msm8974-lge-nexus5-hammerhead.dts    |  31 ++
 drivers/input/misc/Kconfig                    |  10 +
 drivers/input/misc/Makefile                   |   1 +
 drivers/input/misc/msm-vibrator.c             | 282 ++++++++++++++++++
 5 files changed, 360 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/msm-vibrator.txt
 create mode 100644 drivers/input/misc/msm-vibrator.c
Signature · 1 line
2.17.2