Skip to content

RFC ns: Introduce Time Namespace

Dmitry Safonov linux-api linux-kselftest lkml oe-lkp 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest20 patches 36 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20ns: Introduce Time Namespacefs/proc/namespaces.c include/linux/nsproxy.h include/linux/proc_ns.h +8 more+262 -31 reply
2/20timens: Add timens_offsetsinclude/linux/time_namespace.h include/linux/timens_offsets.h kernel/time_namespace.c+22 -22 replies
3/20timens: Introduce CLOCK_MONOTONIC offsetsinclude/linux/timens_offsets.h kernel/time/posix-timers.c+35 -00 replies
4/20timens: Introduce CLOCK_BOOTTIME offsetinclude/linux/timens_offsets.h kernel/time/posix-timers.c+27 -00 replies
5/20timerfd/timens: Take into account ns clock offsetsfs/timerfd.c include/linux/time_namespace.h kernel/time_namespace.c+61 -50 replies
6/20kernel: Take into account timens clock offsets in clock_nanosleepkernel/time/hrtimer.c+8 -00 replies
7/20timens: Shift /proc/uptimefs/proc/uptime.c+3 -00 replies
8/20x86/vdso: Restrict splitting vvar vmaarch/x86/entry/vdso/vma.c+13 -00 replies
9/20x86/vdso/timens: Add offsets page in vvararch/Kconfig arch/x86/Kconfig arch/x86/entry/vdso/vclock_gettime.c +5 more+57 -10 replies
10/20x86/vdso: Use set_normalized_timespec() to avoid 32 bit overflowarch/x86/entry/vdso/vclock_gettime.c+26 -90 replies
11/20x86/vdso: Purge timens page on setns()/unshare()/clone()arch/x86/entry/vdso/vma.c arch/x86/include/asm/vdso.h kernel/time_namespace.c+44 -00 replies
12/20x86/vdso: Look for vvar vma to purge timens pagearch/x86/entry/vdso/vma.c+25 -140 replies
13/20posix-timers/timens: Take into account clock offsetskernel/time/posix-timers.c kernel/time/posix-timers.h+37 -170 replies
14/20timens: Add align for timens_offsetsinclude/linux/timens_offsets.h+9 -20 replies
15/20timens: Optimize zero-offsetsarch/x86/entry/vdso/vclock_gettime.c include/linux/timens_offsets.h kernel/time/posix-timers.c +1 more+36 -160 replies
16/20selftest: Add Time Namespace test for supported clockstools/testing/selftests/timens/.gitignore tools/testing/selftests/timens/Makefile tools/testing/selftests/timens/config +2 more+224 -01 reply
17/20selftest/timens: Add test for timerfdtools/testing/selftests/timens/.gitignore tools/testing/selftests/timens/Makefile tools/testing/selftests/timens/timerfd.c+98 -10 replies
18/20selftest/timens: Add test for clock_nanosleeptools/testing/selftests/timens/.gitignore tools/testing/selftests/timens/Makefile tools/testing/selftests/timens/clock_nanosleep.c+100 -10 replies
19/20timens/selftest: Add procfs selftesttools/testing/selftests/timens/.gitignore tools/testing/selftests/timens/Makefile tools/testing/selftests/timens/procfs.c+147 -10 replies
20/20timens/selftest: Add timer offsets testtools/testing/selftests/timens/.gitignore tools/testing/selftests/timens/Makefile tools/testing/selftests/timens/timer.c+98 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 00/20] ns: Introduce Time Namespace

Discussions around time virtualization are there for a long time. The first attempt to implement time namespace was in 2006 by Jeff Dike.

Quoted 1 line

From that time, the topic appears on and off in various discussions.

There are two main use cases for time namespaces:
1. change date and time inside a container;
2. adjust clocks for a container restored from a checkpoint.

“It seems like this might be one of the last major obstacles keeping migration from being used in production systems, given that not all containers and connections can be migrated as long as a time dependency is capable of messing it up.” (by github.com/dav-ell)

The kernel provides access to several clocks: CLOCK_REALTIME, CLOCK_MONOTONIC, CLOCK_BOOTTIME. Last two clocks are monotonous, but the start points for them are not defined and are different for each running system. When a container is migrated from one node to another, all clocks have to be restored into consistent states; in other words, they have to continue running from the same points where they have been dumped.

The main idea behind this patch set is adding per-namespace offsets for system clocks. When a process in a non-root time namespace requests time of a clock, a namespace offset is added to the current value of this clock on a host and the sum is returned.

All offsets are placed on a separate page, this allows up to map it as part of vvar into user processes and use offsets from vdso calls.

Now offsets are implemented for CLOCK_MONOTONIC and CLOCK_BOOTTIME clocks.

Questions to discuss:

* Clone flags exhaustion. Currently there is only one unused clone flag bit left, and it may be worth to use it to extend arguments of the clone system call.

* Realtime clock implementation details:
Is having a simple offset enough?
What to do when date and time is changed on the host? Is there a need to adjust vfs modification and creation times? Implementation for adjtime() syscall.

Cc Dmitry Safonov <[email protected]>
Cc Adrian Reber <[email protected]>
Cc Andrei Vagin <[email protected]>
Cc Andy Lutomirski <[email protected]>
Cc Christian Brauner <[email protected]>
Cc Cyrill Gorcunov <[email protected]>
Cc "Eric W. Biederman" <[email protected]>
Cc "H. Peter Anvin" <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Jeff Dike <[email protected]>
Cc Oleg Nesterov <[email protected]>
Cc Pavel Emelyanov <[email protected]>
Cc Shuah Khan <[email protected]>
Cc Thomas Gleixner <[email protected]>

Andrei Vagin (12):
ns: Introduce Time Namespace
timens: Add timens_offsets
timens: Introduce CLOCK_MONOTONIC offsets
timens: Introduce CLOCK_BOOTTIME offset timerfd/timens: Take into account ns clock offsets
kernel: Take into account timens clock offsets in clock_nanosleep x86/vdso/timens: Add offsets page in vvar
x86/vdso: Use set_normalized_timespec() to avoid 32 bit overflow posix-timers/timens: Take into account clock offsets selftest/timens: Add test for timerfd
selftest/timens: Add test for clock_nanosleep timens/selftest: Add timer offsets test

Dmitry Safonov (8):
timens: Shift /proc/uptime
x86/vdso: Restrict splitting vvar vma
x86/vdso: Purge timens page on setns()/unshare()/clone() x86/vdso: Look for vvar vma to purge timens page
timens: Add align for timens_offsets
timens: Optimize zero-offsets
selftest: Add Time Namespace test for supported clocks timens/selftest: Add procfs selftest

 arch/Kconfig                                     |   5 +
 arch/x86/Kconfig                                 |   1 +
 arch/x86/entry/vdso/vclock_gettime.c             |  52 +++++
 arch/x86/entry/vdso/vdso-layout.lds.S            |   9 +-
 arch/x86/entry/vdso/vdso2c.c                     |   3 +
 arch/x86/entry/vdso/vma.c                        |  67 +++++++
 arch/x86/include/asm/vdso.h                      |   2 +
 fs/proc/namespaces.c                             |   3 +
 fs/proc/uptime.c                                 |   3 +
 fs/timerfd.c                                     |  16 +-
 include/linux/nsproxy.h                          |   1 +
 include/linux/proc_ns.h                          |   1 +
 include/linux/time_namespace.h                   |  72 +++++++
 include/linux/timens_offsets.h                   |  25 +++
 include/linux/user_namespace.h                   |   1 +
 include/uapi/linux/sched.h                       |   1 +
 init/Kconfig                                     |   8 +
 kernel/Makefile                                  |   1 +
 kernel/fork.c                                    |   3 +-
 kernel/nsproxy.c                                 |  19 +-
 kernel/time/hrtimer.c                            |   8 +
 kernel/time/posix-timers.c                       |  89 ++++++++-
 kernel/time/posix-timers.h                       |   2 +
 kernel/time_namespace.c                          | 230 +++++++++++++++++++++++
 tools/testing/selftests/timens/.gitignore        |   5 +
 tools/testing/selftests/timens/Makefile          |   6 +
 tools/testing/selftests/timens/clock_nanosleep.c |  98 ++++++++++
 tools/testing/selftests/timens/config            |   1 +
 tools/testing/selftests/timens/log.h             |  21 +++
 tools/testing/selftests/timens/procfs.c          | 145 ++++++++++++++
 tools/testing/selftests/timens/timens.c          | 196 +++++++++++++++++++
 tools/testing/selftests/timens/timer.c           |  95 ++++++++++
 tools/testing/selftests/timens/timerfd.c         |  96 ++++++++++
 33 files changed, 1272 insertions(+), 13 deletions(-)
 create mode 100644 include/linux/time_namespace.h
 create mode 100644 include/linux/timens_offsets.h
 create mode 100644 kernel/time_namespace.c
 create mode 100644 tools/testing/selftests/timens/.gitignore
 create mode 100644 tools/testing/selftests/timens/Makefile
 create mode 100644 tools/testing/selftests/timens/clock_nanosleep.c
 create mode 100644 tools/testing/selftests/timens/config
 create mode 100644 tools/testing/selftests/timens/log.h
 create mode 100644 tools/testing/selftests/timens/procfs.c
 create mode 100644 tools/testing/selftests/timens/timens.c
 create mode 100644 tools/testing/selftests/timens/timer.c
 create mode 100644 tools/testing/selftests/timens/timerfd.c
Signature · 1 line
2.13.6