Skip to content

various dynamic_debug patches

Rasmus Villemoes linux-acpi linux-btrfs lkml netdev 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest14 patches 0 repliesNew
  2. v323 patches 2 repliesSuperseded
  3. v223 patches 3 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v122 patches16 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14linux/device.h: use DYNAMIC_DEBUG_BRANCH in dev_dbg_ratelimitedinclude/linux/device.h+1 -10 replies
2/14linux/net.h: use DYNAMIC_DEBUG_BRANCH in net_dbg_ratelimitedinclude/linux/net.h+1 -10 replies
3/14linux/printk.h: use DYNAMIC_DEBUG_BRANCH in pr_debug_ratelimitedinclude/linux/printk.h+1 -10 replies
4/14dynamic_debug: consolidate DEFINE_DYNAMIC_DEBUG_METADATA definitionsinclude/linux/dynamic_debug.h+7 -150 replies
5/14dynamic_debug: don't duplicate modname in ddebug_add_modulelib/dynamic_debug.c+7 -80 replies
6/14dynamic_debug: use pointer comparison in ddebug_remove_modulelib/dynamic_debug.c+2 -10 replies
7/14dynamic_debug: remove unused EXPORT_SYMBOLslib/dynamic_debug.c+0 -20 replies
8/14dynamic_debug: move pr_err from module.c to ddebug_add_modulekernel/module.c lib/dynamic_debug.c+4 -40 replies
9/14dynamic_debug: add static inline stub for ddebug_add_moduleinclude/linux/dynamic_debug.h kernel/module.c+8 -40 replies
10/14dynamic_debug: refactor dynamic_pr_debug and friendsinclude/linux/dynamic_debug.h+43 -290 replies
11/14btrfs: implement btrfs_debug* in terms of helper macrofs/btrfs/ctree.h+10 -240 replies
12/14ACPI: use proper DYNAMIC_DEBUG_BRANCH macroinclude/linux/acpi.h+1 -10 replies
13/14ACPI: remove unused __acpi_handle_debug macroinclude/linux/acpi.h+0 -30 replies
14/14ACPI: implement acpi_handle_debug in terms of _dynamic_func_callinclude/linux/acpi.h+2 -60 replies

Reviews trailers per patch

All 14 patches have a Reviewed-by or Acked-by.

PatchJason BaronRafael J. WysockiGreg Kroah-HartmanDavid SterbaPetr Mladek
1/14A-b R-b
2/14A-b
3/14A-b A-b
4/14A-b
5/14A-b
6/14A-b
7/14A-b
8/14A-b
9/14A-b
10/14A-b
11/14A-b A-b
12/14A-b A-b
13/14A-b A-b
14/14A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v4 thread

Cover letter [PATCH v4 00/14] various dynamic_debug patches

This started as an experiment to see how hard it would be to change the four pointers in struct _ddebug into relative offsets, a la CONFIG_GENERIC_BUG_RELATIVE_POINTERS, thus saving 16 bytes per pr_debug site (and thus exactly making up for the extra space used by the introduction of jump labels in 9049fc74). I stumbled on a few things that are probably worth fixing regardless of whether that goal is deemed worthwhile.

Back at v3 (in November), I redid the implementation on top of the fancy new asm-macros stuff. Luckily enough, v3 didn't get picked up, since the asm-macros were backed out again. I still want to do the relative-pointers thing eventually, but we're close to the merge window opening, so here's just most of the "incidental" patches, some of which also serve as preparation for the relative pointers.

I'm not sure how long an Ack/Reviewed-by is good for, but OTOH it also feels rude to just drop them on the floor. I've kept those tags since the rebasing to current master went completely smooth.

Andrew, please pick these up for soaking in -next.

v3 series: lkml.kernel.org/r/[email protected] v2 series: lkml.kernel.org/r/[email protected]

Rasmus Villemoes (14):
linux/device.h: use DYNAMIC_DEBUG_BRANCH in dev_dbg_ratelimited linux/net.h: use DYNAMIC_DEBUG_BRANCH in net_dbg_ratelimited linux/printk.h: use DYNAMIC_DEBUG_BRANCH in pr_debug_ratelimited
dynamic_debug: consolidate DEFINE_DYNAMIC_DEBUG_METADATA definitions
dynamic_debug: don't duplicate modname in ddebug_add_module
dynamic_debug: use pointer comparison in ddebug_remove_module
dynamic_debug: remove unused EXPORT_SYMBOLs
dynamic_debug: move pr_err from module.c to ddebug_add_module
dynamic_debug: add static inline stub for ddebug_add_module
dynamic_debug: refactor dynamic_pr_debug and friends
btrfs: implement btrfs_debug* in terms of helper macro
ACPI: use proper DYNAMIC_DEBUG_BRANCH macro
ACPI: remove unused __acpi_handle_debug macro
ACPI: implement acpi_handle_debug in terms of _dynamic_func_call

 fs/btrfs/ctree.h              |  34 ++++--------
 include/linux/acpi.h          |  11 +---
 include/linux/device.h        |   2 +-
 include/linux/dynamic_debug.h | 102 +++++++++++++++++++---------------
 include/linux/net.h           |   2 +-
 include/linux/printk.h        |   2 +-
 kernel/module.c               |   6 +-
 lib/dynamic_debug.c           |  22 ++++----
 8 files changed, 84 insertions(+), 97 deletions(-)
Signature · 1 line
2.20.1