Skip to content

nvme-cli: fixup large log page transfer

Keith Busch linux-nvme 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 6 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 6 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] nvme-cli: fixup large log page transfer
Quoted 6 lines · Hannes Reinecke

Hi all,

on large installations the MDTS value might prevent the controller to transfer the entire log page in one go. This patchset updates nvme_get_log() to retrieve the log page in 4k chunks so as having to avoid checking the MDTS value.

That looks good. Shoudn't matter for most pages since only a few may exceed 4k.

Quoted 2 lines

I've also added an 'rae' field to nvme_get_log() to avoid it accidentally clearing outstanding AENs.

Thanks for setting that up!

Quoted 1 line

And the seagate plugin has been cleaned up :-)

I think that code must have been ported from an internal project. :)

Quoted 1 line

As usual, comments and reviews are welcome.

Looks good to me. Patches applied.