Skip to content

net: wean netfilter from fib_nh

[email protected] netdev netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3net/ipv4: Move device validation to helperinclude/net/ip_fib.h net/ipv4/fib_frontend.c+28 -170 replies
2/3netfilter: rpfilter: Convert rpfilter_lookup_reverse to new dev helpernet/ipv4/netfilter/ipt_rpfilter.c+1 -160 replies
3/3netfilter: nft_fib: Convert nft_fib4_eval to new dev helpernet/ipv4/netfilter/nft_fib_ipv4.c+6 -210 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/3] net: wean netfilter from fib_nh

From: David Ahern <[email protected]>

Two netfilter modules reference fib_nh. In both cases the code is only checking if a nexthop in a fib_info uses a specific device. Both instances essentially duplicate code from __fib_validate_source, so move that code into a helper and flip the netfilter modules to use it.

David Ahern (3):
net/ipv4: Move device validation to helper
netfilter: rpfilter: Convert rpfilter_lookup_reverse to new dev helper
netfilter: nft_fib: Convert nft_fib4_eval to new dev helper

 include/net/ip_fib.h              |  1 +
 net/ipv4/fib_frontend.c           | 44 ++++++++++++++++++++++++---------------
 net/ipv4/netfilter/ipt_rpfilter.c | 17 +--------------
 net/ipv4/netfilter/nft_fib_ipv4.c | 27 ++++++------------------
 4 files changed, 35 insertions(+), 54 deletions(-)
Signature · 1 line
2.11.0