Skip to content

netpoll: avoid capture effects for NAPI drivers

Eric Dumazet netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 18 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15netpoll: make ndo_poll_controller() optionalinclude/linux/netpoll.h net/core/netpoll.c+10 -140 replies
2/15bonding: use netpoll_poll_dev() helperdrivers/net/bonding/bond_main.c+2 -91 reply
3/15ixgbe: remove ndo_poll_controllerdrivers/net/ethernet/intel/ixgbe/ixgbe_main.c+0 -250 replies
4/15ixgbevf: remove ndo_poll_controllerdrivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c+0 -210 replies
5/15fm10k: remove ndo_poll_controllerdrivers/net/ethernet/intel/fm10k/fm10k.h drivers/net/ethernet/intel/fm10k/fm10k_netdev.c drivers/net/ethernet/intel/fm10k/fm10k_pci.c+0 -280 replies
6/15ixgb: remove ndo_poll_controllerdrivers/net/ethernet/intel/ixgb/ixgb_main.c+0 -250 replies
7/15igb: remove ndo_poll_controllerdrivers/net/ethernet/intel/igb/igb_main.c+0 -300 replies
8/15ice: remove ndo_poll_controllerdrivers/net/ethernet/intel/ice/ice_main.c+0 -270 replies
9/15i40evf: remove ndo_poll_controllerdrivers/net/ethernet/intel/i40evf/i40evf_main.c+0 -260 replies
10/15mlx4: remove ndo_poll_controllerdrivers/net/ethernet/mellanox/mlx4/en_netdev.c+0 -200 replies
11/15mlx5: remove ndo_poll_controllerdrivers/net/ethernet/mellanox/mlx5/core/en_main.c+0 -190 replies
12/15bnx2x: remove ndo_poll_controllerdrivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c+0 -160 replies
13/15bnxt: remove ndo_poll_controllerdrivers/net/ethernet/broadcom/bnxt/bnxt.c+0 -180 replies
14/15nfp: remove ndo_poll_controllerdrivers/net/ethernet/netronome/nfp/nfp_net_common.c+0 -181 reply
15/15tun: remove ndo_poll_controllerdrivers/net/tun.c+0 -430 replies

Reviews trailers per patch

2 of 15 patches have a Reviewed-by or Acked-by.

PatchSong LiuJakub KicinskiJay Vosburgh
SeriesReviewed-and-tested-by
1/15T-b
2/15A-b
3/15T-b
4/15
5/15
6/15
7/15
8/15
9/15
10/15
11/15
12/15
13/15
14/15A-b T-b
15/15

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH net 00/15] netpoll: avoid capture effects for NAPI drivers

As diagnosed by Song Liu, ndo_poll_controller() can be very dangerous on loaded hosts, since the cpu calling ndo_poll_controller() might steal all NAPI contexts (for all RX/TX queues of the NIC).

This capture, showing one ksoftirqd eating all cycles can last for unlimited amount of time, since one cpu is generally not able to drain all the queues under load.

It seems that all networking drivers that do use NAPI
for their TX completions, should not provide a ndo_poll_controller() :

Most NAPI drivers have netpoll support already handled in core networking stack, since netpoll_poll_dev() uses poll_napi(dev) to iterate through registered NAPI contexts for a device.

This patch series take care of the first round, we will handle other drivers in future rounds.

Eric Dumazet (15):
netpoll: make ndo_poll_controller() optional
bonding: use netpoll_poll_dev() helper
ixgbe: remove ndo_poll_controller
ixgbevf: remove ndo_poll_controller
fm10k: remove ndo_poll_controller
ixgb: remove ndo_poll_controller
igb: remove ndo_poll_controller
ice: remove ndo_poll_controller
i40evf: remove ndo_poll_controller
mlx4: remove ndo_poll_controller
mlx5: remove ndo_poll_controller
bnx2x: remove ndo_poll_controller
bnxt: remove ndo_poll_controller
nfp: remove ndo_poll_controller
tun: remove ndo_poll_controller

 drivers/net/bonding/bond_main.c               | 11 +----
 .../net/ethernet/broadcom/bnx2x/bnx2x_main.c  | 16 -------
 drivers/net/ethernet/broadcom/bnxt/bnxt.c     | 18 --------
 drivers/net/ethernet/intel/fm10k/fm10k.h      |  3 --
 .../net/ethernet/intel/fm10k/fm10k_netdev.c   |  3 --
 drivers/net/ethernet/intel/fm10k/fm10k_pci.c  | 22 ----------
 .../net/ethernet/intel/i40evf/i40evf_main.c   | 26 -----------
 drivers/net/ethernet/intel/ice/ice_main.c     | 27 ------------
 drivers/net/ethernet/intel/igb/igb_main.c     | 30 -------------
 drivers/net/ethernet/intel/ixgb/ixgb_main.c   | 25 -----------
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 25 -----------
 .../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 21 ---------
 .../net/ethernet/mellanox/mlx4/en_netdev.c    | 20 ---------
 .../net/ethernet/mellanox/mlx5/core/en_main.c | 19 --------
 .../ethernet/netronome/nfp/nfp_net_common.c   | 18 --------
 drivers/net/tun.c                             | 43 -------------------
 include/linux/netpoll.h                       |  5 ++-
 net/core/netpoll.c                            | 19 +++-----
 18 files changed, 12 insertions(+), 339 deletions(-)
Signature · 1 line
2.19.0.444.g18242da7ef-goog