Skip to content

Reworked rk3288-tinker-s devicetree

Heiko Stuebner linux-arm-kernel linux-devicetree linux-rockchip 2 versions – New

Get series with b4
b4 am 5476375.mdEj9W728V@phil

Versions newest first · linked by author and title

  1. v4 Latest posting 2/20 of 2 patches 0 repliesNew
  2. v4 posting 1/22 patches 2 repliesSuperseded

Patches in v4 posting 2/2 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/2] Reworked rk3288-tinker-s devicetree

Am Sonntag, 23. September 2018, 13:38:05 CEST schrieb Heiko Stuebner:

Quoted 21 lines

Hi David,

I've adpated your patches 1+2 like so and would like to add them this way later on. Biggest change is of course making patch 1 solely about moving the shared parts to the dtsi and adding the tinker-s.dts including the emmc in the second patch.

Apart from that you can also see some previously missing style-related fixes. For example patch subject lines are somewhat specific, to allow people browsing the git history to realize the core patch contents just from the "headline" and also use the "correct" prefixes which vary depending on the subsystem your changing.

For future patches you can just do a "git log --oneline arch/arm/boot/dts" (change directory depending on location of the change of course), to see that arm32 dts use "ARM: dts: $soc-vendor: foo".

Also providing a commit message describing the individual change in a bit more detail is important.

Quoted 8 lines

The wifi patch is a different issue, so I'll reply there.

Heiko

David Summers (2):
ARM: dts: rockchip: move shared tinker-board nodes to a common dtsi
ARM: dts: rockchip: add rk3288-based Tinker board S

applied for 4.20