Skip to content

staging:rtl8192u: Style & memory leak fix

John Whitmore lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13staging:rtl8192u: Remove HTHalfMcsToDataRate() - Styledrivers/staging/rtl8192u/ieee80211/ieee80211.h drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c+0 -580 replies
2/13staging:rtl8192u: Make HTMcsToDataRate static - Styledrivers/staging/rtl8192u/ieee80211/ieee80211.h drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c+1 -20 replies
3/13staging:rtl8192u: Remove definition of HTSetConnectBwMode - Styledrivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c+0 -10 replies
4/13staging:rtl8192u: Move HTSetConnectBwModeCallback() - Styledrivers/staging/rtl8192u/ieee80211/ieee80211.h drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c+23 -250 replies
5/13staging:rtl8192u: Remove AdvCoding and GreenField - Styledrivers/staging/rtl8192u/ieee80211/rtl819x_HT.h drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c+0 -44 replies
6/13staging:rtl8192u: Remove TxSTBC and RxSTBC - Styledrivers/staging/rtl8192u/ieee80211/rtl819x_HT.h drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c+0 -52 replies
7/13staging:rtl8192u: Remove DelayBA, PSMP and Rsvd1 - Styledrivers/staging/rtl8192u/ieee80211/rtl819x_HT.h drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c+0 -51 reply
8/13staging:rtl8192u: Remove LSigTxopProtect - Styledrivers/staging/rtl8192u/ieee80211/rtl819x_HT.h drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c+1 -20 replies
9/13staging:rtl8192u: Remove Rsvd2 - Styledrivers/staging/rtl8192u/ieee80211/rtl819x_HT.h+0 -10 replies
10/13staging:rtl8192u: Remove ExtHTCapInfo - Styledrivers/staging/rtl8192u/ieee80211/rtl819x_HT.h drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c+0 -60 replies
11/13staging:rtl8192u: Remove TxBFCap - Styledrivers/staging/rtl8192u/ieee80211/rtl819x_HT.h drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c+0 -60 replies
12/13staging:rtl8192u: Remove ASCap - Styledrivers/staging/rtl8192u/ieee80211/rtl819x_HT.h drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c+0 -60 replies
13/13staging:rtl8192u: Remove potential memory leakdrivers/staging/rtl8192u/ieee80211/ieee80211_module.c+5 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/13] staging:rtl8192u: Style & memory leak fix

Back again. I previously went through the struct ht_capability_ele renaming member variables as being unused. At the time I wasn't 100% sure that the structure wasn't memory mapped, or used by external callers to the module, through function pointers or exported symbols. Having had a more detailed look over the code I'm happy that these member variables are not used and have removed them from the code.

The last patch is a potential memory leak, which only happens if two memory allocations succeed and the third allocation fails. So it's probably never going to happen, but fixed it anyhow.

I've tried to find this device, or a datasheet on it, so that I could actually make sure it still worked but that's not been possible. Apparently it's a discontinued device, but that possibly makes it a safer sandbox to start messing with.

John Whitmore (13):
staging:rtl8192u: Remove HTHalfMcsToDataRate() - Style staging:rtl8192u: Make HTMcsToDataRate static - Style staging:rtl8192u: Remove definition of HTSetConnectBwMode - Style staging:rtl8192u: Move HTSetConnectBwModeCallback() - Style staging:rtl8192u: Remove AdvCoding and GreenField - Style staging:rtl8192u: Remove TxSTBC and RxSTBC - Style staging:rtl8192u: Remove DelayBA, PSMP and Rsvd1 - Style staging:rtl8192u: Remove LSigTxopProtect - Style staging:rtl8192u: Remove Rsvd2 - Style staging:rtl8192u: Remove ExtHTCapInfo - Style staging:rtl8192u: Remove TxBFCap - Style staging:rtl8192u: Remove ASCap - Style staging:rtl8192u: Remove potential memory leak

 .../staging/rtl8192u/ieee80211/ieee80211.h    |   3 -
 .../rtl8192u/ieee80211/ieee80211_module.c     |   5 +
 .../staging/rtl8192u/ieee80211/rtl819x_HT.h   |  20 +--
 .../rtl8192u/ieee80211/rtl819x_HTProc.c       | 123 ++++--------------
 4 files changed, 30 insertions(+), 121 deletions(-)
Signature · 1 line
2.18.0