Skip to content

netpoll: second round of fixes.

Eric Dumazet netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11netpoll: do not test NAPI_STATE_SCHED in poll_one_napi()net/core/netpoll.c+1 -192 replies
2/11hinic: remove ndo_poll_controllerdrivers/net/ethernet/huawei/hinic/hinic_main.c+0 -200 replies
3/11ehea: remove ndo_poll_controllerdrivers/net/ethernet/ibm/ehea/ehea_main.c+0 -140 replies
4/11net: hns: remove ndo_poll_controllerdrivers/net/ethernet/hisilicon/hns/hns_enet.c+0 -180 replies
5/11virtio_net: remove ndo_poll_controllerdrivers/net/virtio_net.c+0 -140 replies
6/11qlcnic: remove ndo_poll_controllerdrivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c+0 -450 replies
7/11qlogic: netxen: remove ndo_poll_controllerdrivers/net/ethernet/qlogic/netxen/netxen_nic_main.c+0 -230 replies
8/11net: ena: remove ndo_poll_controllerdrivers/net/ethernet/amazon/ena/ena_netdev.c+0 -220 replies
9/11sfc: remove ndo_poll_controllerdrivers/net/ethernet/sfc/efx.c+0 -261 reply
10/11sfc-falcon: remove ndo_poll_controllerdrivers/net/ethernet/sfc/falcon/efx.c+0 -261 reply
11/11ibmvnic: remove ndo_poll_controllerdrivers/net/ethernet/ibm/ibmvnic.c+0 -160 replies

Reviews trailers per patch

2 of 11 patches have a Reviewed-by or Acked-by.

PatchSong LiuMichael ChanBert Kenward
1/11T-b Reviewed-and-tested-by Reviewed-and-tested-by
2/11
3/11
4/11
5/11
6/11
7/11
8/11
9/11A-b
10/11A-b
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH net 00/11] netpoll: second round of fixes.

As diagnosed by Song Liu, ndo_poll_controller() can be very dangerous on loaded hosts, since the cpu calling ndo_poll_controller() might steal all NAPI contexts (for all RX/TX queues of the NIC).

This capture, showing one ksoftirqd eating all cycles can last for unlimited amount of time, since one cpu is generally not able to drain all the queues under load.

It seems that all networking drivers that do use NAPI
for their TX completions, should not provide a ndo_poll_controller() :

Most NAPI drivers have netpoll support already handled in core networking stack, since netpoll_poll_dev() uses poll_napi(dev) to iterate through registered NAPI contexts for a device.

First patch is a fix in poll_one_napi().

Then following patches take care of ten drivers.

Eric Dumazet (11):
netpoll: do not test NAPI_STATE_SCHED in poll_one_napi()
hinic: remove ndo_poll_controller
ehea: remove ndo_poll_controller
net: hns: remove ndo_poll_controller
virtio_net: remove ndo_poll_controller
qlcnic: remove ndo_poll_controller
qlogic: netxen: remove ndo_poll_controller
net: ena: remove ndo_poll_controller
sfc: remove ndo_poll_controller
sfc-falcon: remove ndo_poll_controller
ibmvnic: remove ndo_poll_controller

 drivers/net/ethernet/amazon/ena/ena_netdev.c  | 22 ---------
 drivers/net/ethernet/hisilicon/hns/hns_enet.c | 18 --------
 .../net/ethernet/huawei/hinic/hinic_main.c    | 20 ---------
 drivers/net/ethernet/ibm/ehea/ehea_main.c     | 14 ------
 drivers/net/ethernet/ibm/ibmvnic.c            | 16 -------
 .../ethernet/qlogic/netxen/netxen_nic_main.c  | 23 ----------
 .../net/ethernet/qlogic/qlcnic/qlcnic_main.c  | 45 -------------------
 drivers/net/ethernet/sfc/efx.c                | 26 -----------
 drivers/net/ethernet/sfc/falcon/efx.c         | 26 -----------
 drivers/net/virtio_net.c                      | 14 ------
 net/core/netpoll.c                            | 20 +--------
 11 files changed, 1 insertion(+), 243 deletions(-)
Signature · 1 line
2.19.0.605.g01d371f741-goog