Tests for readahead() and fadvise() on overlayfs
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest6 patches 6 repliesIn review
- v36 patches 7 repliesSuperseded
- v25 patches 3 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 4 patches | 8 replies | Superseded |
Changes in v4 from the cover letter
- Get rid of check_ret() helper
- Use tst_timer helpers instead of gettimeofday
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | syscalls/readahead02: Convert to newlib and cleanuptestcases/ | +71 | 2 replies | |
| 2/6 | syscalls/readahead02: abort test if readahead syscall failstestcases/ | +12 | 2 replies | |
| 3/6 | syscalls/readahead02: fail test if readahead did not use any cachetestcases/ | +2 | 0 replies | |
| 4/6 | syscalls/readahead02: Convert to tst_timer helperstestcases/ | +8 | 0 replies | |
| 5/6 | syscalls/readahead02: test readahead() on an overlayfs filetestcases/ | +71 | 1 reply | |
| 6/6 | syscalls/readahead02: test readahead using posix_fadvise()testcases/ | +34 | 1 reply |
Reviews trailers per patch
1 of 6 patches has a Reviewed-by or Acked-by.
| Patch | Jan Stancek |
|---|---|
| 1/6 | |
| 2/6 | |
| 3/6 | A-b |
| 4/6 | |
| 5/6 | |
| 6/6 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/6] Tests for readahead() and fadvise() on overlayfs
Cyril,
The following series adds test covergae for readahead() syscall over overlayfs file and adds test coverage for a specific posix_fadvise() syscall advice (POSIX_FADV_WILLNEED).
So far, the posix_fadvise syscall tests in LTP only test for error conditions, but not functionality.
The functionality of the advice POSIX_FADV_WILLNEED is identical to readahead() and since kernel commit 3d8f7615319b ("vfs: implement readahead(2) using POSIX_FADV_WILLNEED"), the implementations are also bound together.
To add test coverage of the advice POSIX_FADV_WILLNEED, I decided not to duplicate the readahead() functional test and add test cases to readahead02 that use the POSIX_FADV_WILLNEED implementation.
Thanks,
Amir.
Changed since v3:
- Get rid of check_ret() helper
- Use tst_timer helpers instead of gettimeofday
Changes since v2:
- Runtime check for readahead/fadvise support
- Abort test case immediately if syscall fail
Changes since v1:
- Fix bugs in loop invocation of test (i.e. -i 2)
- Address review comments from Jan Stancek
- Make cached_max a global maximum over all test cases
- Improve reliability of overlayfs readahead test case failure
Amir Goldstein (6):
syscalls/readahead02: Convert to newlib and cleanup syscalls/readahead02: abort test if readahead syscall fails syscalls/readahead02: fail test if readahead did not use any cache syscalls/readahead02: Convert to tst_timer helpers syscalls/readahead02: test readahead() on an overlayfs file syscalls/readahead02: test readahead using posix_fadvise()
.../kernel/syscalls/readahead/readahead02.c | 355 ++++++++---------- 1 file changed, 164 insertions(+), 191 deletions(-)
Signature · 1 line
2.17.1