Skip to content

Fix dump requests to use proper header for type

David Ahern netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11libnetlink: Convert GETADDR dumps to use rtnl_addrdump_reqinclude/libnetlink.h ip/ipaddress.c lib/libnetlink.c+23 -32 replies
2/11libnetlink: Convert GETROUTE dumps to use rtnl_routedump_reqinclude/libnetlink.h ip/ipmroute.c ip/iproute.c +1 more+21 -30 replies
3/11libnetlink: Convert GETADDRLABEL dumps to use rtnl_addrlbldump_reqinclude/libnetlink.h ip/ipaddrlabel.c lib/libnetlink.c+21 -20 replies
4/11libnetlink: Convert GETMDB dumps to use rtnl_mdbdump_reqbridge/mdb.c include/libnetlink.h lib/libnetlink.c+20 -10 replies
5/11libnetlink: Convert GETNETCONF dumps to use rtnl_netconfdump_reqinclude/libnetlink.h ip/ipnetconf.c lib/libnetlink.c+19 -20 replies
6/11libnetlink: Convert GETRULE dumps to use rtnl_ruledump_reqinclude/libnetlink.h ip/iprule.c lib/libnetlink.c+20 -10 replies
7/11libnetlink: Convert GETNEIGH dumps to use rtnl_neighdump_reqinclude/libnetlink.h lib/libnetlink.c misc/arpd.c+19 -10 replies
8/11libnetlink: Convert GETNEIGHTBL dumps to use rtnl_neightbldump_reqinclude/libnetlink.h ip/ipntable.c lib/libnetlink.c+19 -10 replies
9/11libnetlink: Convert GETNSID dumps to use rtnl_nsiddump_reqinclude/libnetlink.h ip/ipnetns.c lib/libnetlink.c+19 -10 replies
10/11libnetlink: Rename rtnl_wilddump_* to rtnl_linkdump_*bridge/link.c bridge/vlan.c include/libnetlink.h +8 more+20 -210 replies
11/11libnetlink: Rename rtnl_wilddump_stats_req_filter to rtnl_statsdump_req_filterbridge/vlan.c include/libnetlink.h ip/iplink.c +3 more+9 -190 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH iproute2-next 00/11] Fix dump requests to use proper header for type

From: David Ahern <[email protected]>

iproute2 currently uses ifinfomsg as the header for all dumps using the wilddump headers. This is wrong as each message type actually has its own header type. While the kernel has traditionally let it go as it for the most part only uses the family entry, the use of kernel side filters is increasing to alter what is returned on a request. The kernel side filters really need to use the proper header type.

To that end, fix iproute2 to use the proper header struct for the GET type.

David Ahern (11):
libnetlink: Convert GETADDR dumps to use rtnl_addrdump_req
libnetlink: Convert GETROUTE dumps to use rtnl_routedump_req
libnetlink: Convert GETADDRLABEL dumps to use rtnl_addrlbldump_req
libnetlink: Convert GETMDB dumps to use rtnl_mdbdump_req
libnetlink: Convert GETNETCONF dumps to use rtnl_netconfdump_req
libnetlink: Convert GETRULE dumps to use rtnl_ruledump_req
libnetlink: Convert GETNEIGH dumps to use rtnl_neighdump_req
libnetlink: Convert GETNEIGHTBL dumps to use rtnl_neightbldump_req
libnetlink: Convert GETNSID dumps to use rtnl_nsiddump_req
libnetlink: Rename rtnl_wilddump_* to rtnl_linkdump_*
libnetlink: Rename rtnl_wilddump_stats_req_filter to
rtnl_statsdump_req_filter

 bridge/link.c        |   4 +-
 bridge/mdb.c         |   2 +-
 bridge/vlan.c        |  10 +---
 include/libnetlink.h |  30 ++++++++--
 ip/ipaddress.c       |  10 ++--
 ip/ipaddrlabel.c     |   4 +-
 ip/iplink.c          |   4 +-
 ip/iplink_xstats.c   |   4 +-
 ip/ipmroute.c        |   2 +-
 ip/ipnetconf.c       |   3 +-
 ip/ipnetns.c         |   2 +-
 ip/ipntable.c        |   2 +-
 ip/iproute.c         |   4 +-
 ip/iprule.c          |   2 +-
 ip/iptoken.c         |   2 +-
 ip/iptuntap.c        |   2 +-
 ip/rtmon.c           |   2 +-
 ip/tunnel.c          |   2 +-
 lib/libnetlink.c     | 164 ++++++++++++++++++++++++++++++++++++++++++++++++---
 lib/ll_map.c         |   2 +-
 misc/arpd.c          |   2 +-
 misc/ifstat.c        |   6 +-
 22 files changed, 210 insertions(+), 55 deletions(-)
Signature · 1 line
2.11.0