Skip to content

USB: serial: gpio line-name fix and FT232R CBUS gpio support

Johan Hovold linux-gpio linux-usb lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2USB: serial: ftdi_sio: fix gpio name collisionsdrivers/usb/serial/ftdi_sio.c+0 -50 replies
2/2USB: serial: ftdi_sio: add support for FT232R CBUS gpiosdrivers/usb/serial/ftdi_sio.c drivers/usb/serial/ftdi_sio.h+40 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] USB: serial: gpio line-name fix and FT232R CBUS gpio support

Turns out gpiolib still doesn't like having non-unique line names, so drop the line names from the recently added FTX cbus gpio implementation before adding support also for FT232R.

Linus, we finally got around to adding gpio support for FTDI devices; see commit

ba93cc7da896 ("USB: serial: ftdi_sio: implement GPIO support for FT-X devices")

in my usb-next branch (and linux-next).

The gpiolib warnings and inability to use the legacy sysfs interface prevents us from setting the line names however as someone is bound to plugin more than one of these devices at some point. I think we discussed this issue with the name space and hotpluggable devices a few years ago, but looks like this topic may need to be revisited.

Thanks,
Johan

Johan Hovold (2):
USB: serial: ftdi_sio: fix gpio name collisions
USB: serial: ftdi_sio: add support for FT232R CBUS gpios

 drivers/usb/serial/ftdi_sio.c | 45 +++++++++++++++++++++++++++++------
 drivers/usb/serial/ftdi_sio.h |  3 ++-
 2 files changed, 40 insertions(+), 8 deletions(-)
Signature · 1 line
2.19.0