Skip to content

fleecing-hook driver for backup

Vladimir Sementsov-Ogievskiy qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest18 patches 16 repliesIn review

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18block/dirty-bitmap: allow set/reset bits in disabled bitmapsblock/dirty-bitmap.c+0 -22 replies
2/18block/io: allow BDRV_REQ_SERIALISING for readblock/io.c+6 -70 replies
3/18block/backup: simplify backup_incremental_init_copy_bitmapblock/backup.c+12 -280 replies
4/18block/backup: move from HBitmap to BdrvDirtyBitmapblock/backup.c+41 -320 replies
5/18util/id: add block-bitmap subsysteminclude/qemu/id.h util/id.c+2 -00 replies
6/18block/backup: give a name to copy-bitmapblock/backup.c block/replication.c blockdev.c +2 more+36 -80 replies
7/18block/backup: allow use existent copy-bitmapblock/backup.c+10 -40 replies
8/18block: allow serialized reads to intersectblock/io.c+2 -10 replies
9/18block: improve should_update_childblock.c+27 -50 replies
10/18iotests: handle -f argument correctly for qemu_io_silenttests/qemu-iotests/iotests.py+6 -10 replies
11/18iotests: allow resume_drive by node nametests/qemu-iotests/iotests.py+5 -40 replies
12/18iotests: prepare 055 to graph changes during backup jobtests/qemu-iotests/055+13 -100 replies
13/18block: introduce new filter driver: fleecing-hookblock/Makefile.objs block/fleecing-hook.c qapi/block-core.json+320 -29 replies
14/18block/fleecing-hook: internal apiblock/fleecing-hook.c include/block/block.h+60 -01 reply
15/18qapi: add x-drop-fleecing qmp commandblockdev.c qapi/block-core.json+54 -00 replies
16/18iotests: test new fleecing-hook driver in context of 222 iotesttests/qemu-iotests/222 tests/qemu-iotests/222.out+114 -110 replies
17/18block/backup: tiny refactor backup_job_createblock/backup.c+52 -430 replies
18/18block/backup: use fleecing-hook instead of write notifiersblock/backup.c+45 -971 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 00/18] fleecing-hook driver for backup

v2 was "[RFC v2] new, node-graph-based fleecing and backup"

Hi all!

These series introduce fleecing-hook driver. It's a filter-node, which do copy-before-write operation. Mirror uses filter-node for handling guest writes, let's move to filter-node (from write-notifiers) for backup too (patch 18)

Proposed filter driver is complete and separate: it can be used standalone, as fleecing provider (instead of backup(sync=none)). (old-style fleecing based on backup(sync=none) is supported too), look at patch 16.

There a lot of other ideas and improvements which can be achieved basing on these series which were discussed on v2 thread, for the beginning I want to concentrate on the following:

done in these series:
1. use filter node instead of write notifiers in backup
2. filter-based fleecing scheme, without a job

near to be done (a test is needed and may be tiny adjustment)
3. backup scheme for push backup with fleecing, to no disturb the guest with long handling of its writes (if target is far from remote NBD): just start fleecing to local qcow2 temp node and start a backup job (or mirror, why not?) from temp node to remote target. These series provide a possibility to share dirty bitmap between fleecing-hook and backup job to create efficient scenarios.

These series are based on
[PATCH v4 0/8] dirty-bitmap: rewrite bdrv_dirty_iter_next_area
and
[PATCH 0/2] replication: drop extra sync

Based-on: <[email protected]>
Based-on: <[email protected]>

Vladimir Sementsov-Ogievskiy (18):
block/dirty-bitmap: allow set/reset bits in disabled bitmaps block/io: allow BDRV_REQ_SERIALISING for read block/backup: simplify backup_incremental_init_copy_bitmap block/backup: move from HBitmap to BdrvDirtyBitmap util/id: add block-bitmap subsystem
block/backup: give a name to copy-bitmap block/backup: allow use existent copy-bitmap
block: allow serialized reads to intersect
block: improve should_update_child
iotests: handle -f argument correctly for qemu_io_silent
iotests: allow resume_drive by node name
iotests: prepare 055 to graph changes during backup job
block: introduce new filter driver: fleecing-hook block/fleecing-hook: internal api
qapi: add x-drop-fleecing qmp command
iotests: test new fleecing-hook driver in context of 222 iotest block/backup: tiny refactor backup_job_create block/backup: use fleecing-hook instead of write notifiers

 qapi/block-core.json          |  57 +++++-
 include/block/block.h         |   9 +
 include/block/block_int.h     |   2 +-
 include/qemu/id.h             |   1 +
 block.c                       |  32 +++-
 block/backup.c                | 320 ++++++++++++++-----------------
 block/dirty-bitmap.c          |   2 -
 block/fleecing-hook.c         | 349 ++++++++++++++++++++++++++++++++++
 block/io.c                    |  16 +-
 block/replication.c           |   2 +-
 blockdev.c                    |  49 ++++-
 util/id.c                     |   1 +
 block/Makefile.objs           |   2 +
 tests/qemu-iotests/055        |  23 ++-
 tests/qemu-iotests/222        |  59 ++++--
 tests/qemu-iotests/222.out    |  66 +++++++
 tests/qemu-iotests/iotests.py |  16 +-
 17 files changed, 778 insertions(+), 228 deletions(-)
 create mode 100644 block/fleecing-hook.c
Signature · 1 line
2.18.0