dirty-bitmaps: fix QMP command permissions
Status from this message: Thanks, applied to my bitmaps tree: [with edits suggested by Vladimir];
Get series with b4
b4 am [email protected]Versions newest first
Changes in v4 from the cover letter
- Replace "in-use" with "in use"
- Replace "user_modifiable" version with "user_locked"
- Remove more usages of frozen-and-or-locked in NBD.
Patches in v4 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | block/dirty-bitmaps: add user_locked status checkerblock/ blockdev.c include/ +1 more | +17 | 4 replies | |
| 2/6 | block/dirty-bitmaps: fix merge permissionsblock/ | +3 | 2 replies | |
| 3/6 | block/dirty-bitmaps: allow clear on disabled bitmapsblock/ blockdev.c | +0 | 2 replies | |
| 4/6 | block/dirty-bitmaps: prohibit enable/disable on locked/frozen bitmapsblockdev.c | +20 | 2 replies | |
| 5/6 | block/backup: prohibit backup from using in use bitmapsblockdev.c | +6 | 4 replies | |
| 6/6 | nbd: forbid use of frozen bitmapsnbd/ | +2 | 2 replies |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Eric Blake | Vladimir Sementsov-Ogievskiy |
|---|---|---|
| 1/6 | R-b | R-b |
| 2/6 | R-b | R-b |
| 3/6 | R-b | R-b |
| 4/6 | R-b | R-b |
| 5/6 | R-b | |
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v4 0/6] dirty-bitmaps: fix QMP command permissions
based on: jsnow/bitmaps staging branch
This series builds on a previous standalone patch and adjusts the permission for all (or most) of the QMP bitmap commands.
V4:
- Replace "in-use" with "in use"
- Replace "user_modifiable" version with "user_locked"
- Remove more usages of frozen-and-or-locked in NBD.
John Snow (6):
block/dirty-bitmaps: add user_locked status checker block/dirty-bitmaps: fix merge permissions block/dirty-bitmaps: allow clear on disabled bitmaps block/dirty-bitmaps: prohibit enable/disable on locked/frozen bitmaps block/backup: prohibit backup from using in use bitmaps
nbd: forbid use of frozen bitmaps
block/dirty-bitmap.c | 13 +++++--- blockdev.c | 75 +++++++++++++++++++----------------------- include/block/dirty-bitmap.h | 1 + migration/block-dirty-bitmap.c | 10 ++---- nbd/server.c | 4 +-- 5 files changed, 48 insertions(+), 55 deletions(-)
Signature · 1 line
2.14.4