Skip to content

replace attach/detach functions

Thomas Monjalon dpdk-dev 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest7 patches 7 repliesIn review
  2. v67 patches 2 repliesSuperseded
  3. v57 patches 1 replySuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v46 patches4 repliesSuperseded
v36 patches1 replySuperseded
v26 patches7 repliesSuperseded
v15 patches9 repliesSuperseded

Changes in v7 from the cover letter

- remove use of eth_dev->data->name after detach in testpmd

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7bus/vdev: add iteration filter on namedrivers/bus/vdev/vdev_params.c+17 -20 replies
2/7ethdev: add iterator to match devargs inputlib/librte_eal/common/include/rte_common.h lib/librte_ethdev/ethdev_private.c lib/librte_ethdev/ethdev_private.h +4 more+232 -20 replies
3/7ethdev: allow iterating with pure class filterlib/librte_ethdev/rte_class_eth.c lib/librte_ethdev/rte_ethdev.c+23 -40 replies
4/7doc: replace doxygen example in contribution guidedoc/guides/contributing/documentation.rst+5 -100 replies
5/7ethdev: remove deprecated attach/detach functionsapp/test-pmd/testpmd.c doc/guides/prog_guide/index.rst doc/guides/prog_guide/port_hotplug_framework.rst +6 more+22 -2350 replies
6/7eal: remove deprecated attach/detach functionsdoc/guides/rel_notes/deprecation.rst doc/guides/rel_notes/release_18_11.rst lib/librte_eal/common/eal_common_dev.c +2 more+6 -870 replies
7/7app/testpmd: check not detaching device twiceapp/test-pmd/testpmd.c+21 -36 replies

Reviews trailers per patch

6 of 7 patches have a Reviewed-by or Acked-by.

PatchAndrew Rybchenko
1/7R-b
2/7R-b
3/7R-b
4/7R-b
5/7R-b
6/7R-b
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 0/7] replace attach/detach functions

The functions for EAL attach/detach had already some replacements, so they are removed.
The functions for ethdev attach/detach are removed and replaced thanks to a new ethdev iterator working with devargs.

rte_eth_dev_attach(devargs, &port_id)
is replaced by:

    rte_dev_probe(devargs);
    RTE_ETH_FOREACH_MATCHING_DEV(port_id, devargs, &iterator) {
        do what you want with the new port_id
    }

The biggest benefit is to be able to manage devargs string matching several ports to probe.

Changes in v7:
- remove use of eth_dev->data->name after detach in testpmd

Changes in v6:
- improve testpmd logs
- update testpmd port_status when detaching multiple ports

Changes in v5:
- check double detach in testpmd

Changes in v4:
- fix compilation (due to stricter checks in v3)

Changes in v3 - after Andrew's review:
- coding rules compliance
- stricter checks for snprintf
- rte_eth_iterator_free() becomes rte_eth_iterator_cleanup()
- add rte_eth_iterator_cleanup in .map

Changes in v2 - after Andrew's review:
- return only 0 or -1 in vdev_dev_match()
- fix freeing of strings in the iterator
- add rte_eth_iterator_free()
- tolerate extra parameters from old syntax
- add more comments
- separate contributing guide patch

Thomas Monjalon (7):
bus/vdev: add iteration filter on name
ethdev: add iterator to match devargs input
ethdev: allow iterating with pure class filter
doc: replace doxygen example in contribution guide
ethdev: remove deprecated attach/detach functions
eal: remove deprecated attach/detach functions app/testpmd: check not detaching device twice

 app/test-pmd/testpmd.c                        |  42 +++-
 doc/guides/contributing/documentation.rst     |  15 +-
 doc/guides/prog_guide/index.rst               |   1 -
 .../prog_guide/port_hotplug_framework.rst     | 106 ---------
 doc/guides/rel_notes/deprecation.rst          |  12 -
 doc/guides/rel_notes/release_18_11.rst        |  12 +
 drivers/bus/vdev/vdev_params.c                |  19 +-
 drivers/net/virtio/virtio_user_ethdev.c       |   1 -
 lib/librte_eal/common/eal_common_dev.c        |  53 -----
 lib/librte_eal/common/include/rte_common.h    |   6 +
 lib/librte_eal/common/include/rte_dev.h       |  27 ---
 lib/librte_eal/rte_eal_version.map            |   2 -
 lib/librte_ethdev/ethdev_private.c            |  10 +-
 lib/librte_ethdev/ethdev_private.h            |   6 +
 lib/librte_ethdev/rte_class_eth.c             |   9 +-
 lib/librte_ethdev/rte_ethdev.c                | 223 +++++++++++-------
 lib/librte_ethdev/rte_ethdev.h                | 110 ++++++---
 lib/librte_ethdev/rte_ethdev_version.map      |   5 +-
 18 files changed, 321 insertions(+), 338 deletions(-)
 delete mode 100644 doc/guides/prog_guide/port_hotplug_framework.rst
Signature · 1 line
2.19.0