replace attach/detach functions
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v7 Latest7 patches 7 repliesIn review
- v67 patches 2 repliesSuperseded
- v57 patches 1 replySuperseded
Earlier versions · 4
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v4 | 6 patches | 4 replies | Superseded | |
| v3 | 6 patches | 1 reply | Superseded | |
| v2 | 6 patches | 7 replies | Superseded | |
| v1 | 5 patches | 9 replies | Superseded |
Changes in v7 from the cover letter
- remove use of eth_dev->data->name after detach in testpmd
Patches in v7 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | bus/vdev: add iteration filter on namedrivers/ | +17 | 0 replies | |
| 2/7 | ethdev: add iterator to match devargs inputlib/ lib/ lib/ +4 more | +232 | 0 replies | |
| 3/7 | ethdev: allow iterating with pure class filterlib/ lib/ | +23 | 0 replies | |
| 4/7 | doc: replace doxygen example in contribution guidedoc/ | +5 | 0 replies | |
| 5/7 | ethdev: remove deprecated attach/detach functionsapp/ doc/ doc/ +6 more | +22 | 0 replies | |
| 6/7 | eal: remove deprecated attach/detach functionsdoc/ doc/ lib/ +2 more | +6 | 0 replies | |
| 7/7 | app/testpmd: check not detaching device twiceapp/ | +21 | 6 replies |
Reviews trailers per patch
6 of 7 patches have a Reviewed-by or Acked-by.
| Patch | Andrew Rybchenko |
|---|---|
| 1/7 | R-b |
| 2/7 | R-b |
| 3/7 | R-b |
| 4/7 | R-b |
| 5/7 | R-b |
| 6/7 | R-b |
| 7/7 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v7 0/7] replace attach/detach functions
The functions for EAL attach/detach had already some replacements, so they are removed.
The functions for ethdev attach/detach are removed and replaced thanks to a new ethdev iterator working with devargs.
rte_eth_dev_attach(devargs, &port_id)
is replaced by:
rte_dev_probe(devargs);
RTE_ETH_FOREACH_MATCHING_DEV(port_id, devargs, &iterator) {
do what you want with the new port_id
}The biggest benefit is to be able to manage devargs string matching several ports to probe.
Changes in v7:
- remove use of eth_dev->data->name after detach in testpmd
Changes in v6:
- improve testpmd logs
- update testpmd port_status when detaching multiple ports
Changes in v5:
- check double detach in testpmd
Changes in v4:
- fix compilation (due to stricter checks in v3)
Changes in v3 - after Andrew's review:
- coding rules compliance
- stricter checks for snprintf
- rte_eth_iterator_free() becomes rte_eth_iterator_cleanup()
- add rte_eth_iterator_cleanup in .map
Changes in v2 - after Andrew's review:
- return only 0 or -1 in vdev_dev_match()
- fix freeing of strings in the iterator
- add rte_eth_iterator_free()
- tolerate extra parameters from old syntax
- add more comments
- separate contributing guide patch
Thomas Monjalon (7):
bus/vdev: add iteration filter on name
ethdev: add iterator to match devargs input
ethdev: allow iterating with pure class filter
doc: replace doxygen example in contribution guide
ethdev: remove deprecated attach/detach functions
eal: remove deprecated attach/detach functions app/testpmd: check not detaching device twice
app/test-pmd/testpmd.c | 42 +++- doc/guides/contributing/documentation.rst | 15 +- doc/guides/prog_guide/index.rst | 1 - .../prog_guide/port_hotplug_framework.rst | 106 --------- doc/guides/rel_notes/deprecation.rst | 12 - doc/guides/rel_notes/release_18_11.rst | 12 + drivers/bus/vdev/vdev_params.c | 19 +- drivers/net/virtio/virtio_user_ethdev.c | 1 - lib/librte_eal/common/eal_common_dev.c | 53 ----- lib/librte_eal/common/include/rte_common.h | 6 + lib/librte_eal/common/include/rte_dev.h | 27 --- lib/librte_eal/rte_eal_version.map | 2 - lib/librte_ethdev/ethdev_private.c | 10 +- lib/librte_ethdev/ethdev_private.h | 6 + lib/librte_ethdev/rte_class_eth.c | 9 +- lib/librte_ethdev/rte_ethdev.c | 223 +++++++++++------- lib/librte_ethdev/rte_ethdev.h | 110 ++++++--- lib/librte_ethdev/rte_ethdev_version.map | 5 +- 18 files changed, 321 insertions(+), 338 deletions(-) delete mode 100644 doc/guides/prog_guide/port_hotplug_framework.rst
Signature · 1 line
2.19.0