block: Add auto-read-only option
Status from this message: Applied to the block branch (with the added hunk in patch 2).
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest11 patches 4 repliesApplied
- v39 patches 6 repliesSuperseded
- v28 patches 14 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 4 patches | 1 reply | Superseded |
Changes in v4 from the cover letter
- Split fix for missing rbd_close() into a separate patch [Eric]
- Added qemu-iotests case
Patches in v4 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | block: Update flags in bdrv_set_read_only()block.c | +7 | 0 replies | |
| 2/11 | block: Add auto-read-only optionblock.c block/ include/ +1 more | +27 | 1 reply | |
| 3/11 | rbd: Close image in qemu_rbd_open() error pathblock/ | +1 | 1 reply | |
| 4/11 | block: Require auto-read-only for existing fallbacksblock.c block/ block/ +4 more | +51 | 0 replies | |
| 5/11 | nbd: Support auto-read-only optionblock/ | +5 | 0 replies | |
| 6/11 | file-posix: Support auto-read-only optionblock/ | +16 | 0 replies | |
| 7/11 | curl: Support auto-read-only optionblock/ | +4 | 0 replies | |
| 8/11 | gluster: Support auto-read-only optionblock/ | +10 | 0 replies | |
| 9/11 | iscsi: Support auto-read-only optionblock/ | +5 | 0 replies | |
| 10/11 | block: Make auto-read-only=on default for -driveblockdev.c | +1 | 0 replies | |
| 11/11 | qemu-iotests: Test auto-read-only with -drive and -blockdevtests/ tests/ tests/ | +207 | 1 reply |
Reviews trailers per patch
All 11 patches have a Reviewed-by or Acked-by.
| Patch | Eric Blake | Alberto Garcia | Niels de Vos |
|---|---|---|---|
| 1/11 | R-b | R-b | |
| 2/11 | R-b | ||
| 3/11 | R-b | ||
| 4/11 | R-b | ||
| 5/11 | R-b | ||
| 6/11 | R-b | ||
| 7/11 | R-b | ||
| 8/11 | R-b | ||
| 9/11 | R-b | ||
| 10/11 | R-b | ||
| 11/11 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [Qemu-devel] [PATCH v4 00/11] block: Add auto-read-only option
See patch 2 for an explanation of the motivation.
v4:
- Split fix for missing rbd_close() into a separate patch [Eric]
- Added qemu-iotests case
v3:
- Clarified QAPI schema documentation that auto-read-only can only degrade read-write to read-only, not the other way round [Eric]
- Don't refuse to set copy-on-read=on and auto-read-only=on at the same time; only complain when actually trying to degrade to read-only
- Let bdrv_apply_auto_read_only() return -EACCESS on all errors
- Fixed file-posix and gluster implementations [Eric, Niels]
- Added a patch to make auto-read-only=on the default for human user interfaces (-drive/-hda/...)
v2:
- Turn bdrv_set_read_only() into bdrv_apply_auto_read_only()
- Support the option in a lot more block drivers
Kevin Wolf (11):
block: Update flags in bdrv_set_read_only()
block: Add auto-read-only option
rbd: Close image in qemu_rbd_open() error path
block: Require auto-read-only for existing fallbacks
nbd: Support auto-read-only option
file-posix: Support auto-read-only option
curl: Support auto-read-only option
gluster: Support auto-read-only option
iscsi: Support auto-read-only option
block: Make auto-read-only=on default for -drive
qemu-iotests: Test auto-read-only with -drive and -blockdev
qapi/block-core.json | 7 ++ include/block/block.h | 5 +- block.c | 54 +++++++++++--- block/bochs.c | 17 ++--- block/cloop.c | 16 ++-- block/curl.c | 8 +- block/dmg.c | 16 ++-- block/file-posix.c | 19 ++++- block/gluster.c | 12 ++- block/iscsi.c | 8 +- block/nbd-client.c | 10 +-- block/rbd.c | 14 +--- block/vvfat.c | 11 +-- blockdev.c | 1 + tests/qemu-iotests/232 | 147 +++++++++++++++++++++++++++++++++++++ tests/qemu-iotests/232.out | 59 +++++++++++++++ tests/qemu-iotests/group | 1 + 17 files changed, 327 insertions(+), 78 deletions(-) create mode 100755 tests/qemu-iotests/232 create mode 100644 tests/qemu-iotests/232.out
Signature · 1 line
2.19.1