Skip to content

add an advice on unqualified <dst> push

Ævar Arnfjörð Bjarmason git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2i18n: remote.c: mark error(...) messages for translationremote.c+17 -171 reply
2/2push: add an advice on unqualified <dst> pushDocumentation/config.txt advice.c advice.h +2 more+90 -749 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] add an advice on unqualified <dst> push

Years ago I accidentally deleted the "master" branch at work (due to git push origin $emptyvar:master), and while I could tell from the reflogs what SHA-1 I needed on the other side ran into the fairly cryptic error message, certainly to me when the adrenaline is flowing and you've just ruined something in production.

So this series makes that error message better, and suggests to the user how they can fix the situation, first I needed to mark some strings in remote.c for i18n.

It would be better if we could just give the user a full command to copy/paste, i.e. what the ran but with refs/{heads,tags}/<their-ref>, but between passing the remote name down, and handling any push options I think it's better for now just to suggest the refspec.

Ævar Arnfjörð Bjarmason (2):
i18n: remote.c: mark error(...) messages for translation
push: add an advice on unqualified <dst> push

 Documentation/config.txt |  7 ++++
 advice.c                 |  2 +
 advice.h                 |  1 +
 remote.c                 | 86 +++++++++++++++++++++++++++++++---------
 t/t5505-remote.sh        | 25 ++++++++++++
 5 files changed, 102 insertions(+), 19 deletions(-)
Signature · 1 line
2.19.1.390.gf3a00b506f