Skip to content

Label initialization time optimizations

Alexander Duyck linux-nvdimm nvdimm 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6libnvdimm, dimm: Maximize label transfer sizedrivers/nvdimm/dimm_devs.c+6 -70 replies
2/6nvdimm: Sanity check labeloffdrivers/nvdimm/label.c+7 -00 replies
3/6nvdimm: Clarify comment in sizeof_namespace_indexdrivers/nvdimm/label.c+2 -10 replies
4/6nvdimm: Remove empty if statementdrivers/nvdimm/label.c+2 -30 replies
5/6nvdimm: Split label init out from the logic for getting config datadrivers/nvdimm/dimm.c drivers/nvdimm/dimm_devs.c drivers/nvdimm/label.c +2 more+61 -310 replies
6/6nvdimm: Use namespace index data to reduce number of label reads neededdrivers/nvdimm/dimm.c drivers/nvdimm/label.c drivers/nvdimm/label.h+88 -121 reply

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchToshi Kani
SeriesR-b
1/6
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [nvdimm PATCH 0/6] Label initialization time optimizations

This patch set is intended to improve NVDIMM label read times by first increasing the upper limit on the label read/write size, and then reducing the number of reads by making use of the free label bitmap in the index to determine what labels are actually populated and only read those labels. In my testing on a system populated with 24 NVDIMM modules I see the total label init time drop from about 24 seconds down to 2 to 3 seconds.

In the process of coding this up I came across a few minor issues that I felt should be addressed so I have added a few patches for those fixes along the way.

---

Alexander Duyck (5):
nvdimm: Sanity check labeloff
nvdimm: Clarify comment in sizeof_namespace_index
nvdimm: Remove empty if statement
nvdimm: Split label init out from the logic for getting config data
nvdimm: Use namespace index data to reduce number of label reads needed

Dan Williams (1):
libnvdimm, dimm: Maximize label transfer size

 drivers/nvdimm/dimm.c      |    6 --
 drivers/nvdimm/dimm_devs.c |   60 +++++++------------
 drivers/nvdimm/label.c     |  142 ++++++++++++++++++++++++++++++++++++++++++--
 drivers/nvdimm/label.h     |    4 -
 drivers/nvdimm/nd.h        |    2 +
 5 files changed, 163 insertions(+), 51 deletions(-)

--
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm