Skip to content

init scripts: rewrite S01logging

Thomas Petazzoni buildroot 4 versions – New

Get series with b4
b4 am 20181103114416.17be42df@windsurf

Versions newest first · linked by author and title

  1. v3 Latest posting 4/40 of 8 patches 0 repliesNew
  2. v3 posting 3/40 of 8 patches 0 repliesSuperseded
  3. v3 posting 2/40 of 8 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v3 posting 1/40 of 8 patches0 repliesSuperseded

Patches in v3 posting 4/4 No applies recorded yet

None of the 8 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [Buildroot] [PATCH v3 0/8] init scripts: rewrite S01logging

Hello,

Quoted 10 lines · Arnout Vandecappelle
Quoted 5 lines

To me, this is exactly like what happens if you enable both Dropbear and OpenSSH. It installs two init scripts with different names, even if in practice, only one SSH server will start. We don't handle this "conflict" for the SSH servers, I don't see why we should have some special thing to handle it for logging daemons.

There is one big difference with the HTTP daemon, however: even if busybox
httpd is enabled, we don't install an init script for it. However, S01logging is installed unconditionally, even if the user didn't consciously choose for busybox as its logging provider.

Well, my point was not simply for Busybox HTTP server, but for HTTP servers in general. We have S50apache and S50lighttpd for example, and possibly others as well. We have S50dropbear and S50sshd.

So the problem doesn't exist today for the Busybox HTTP server, because we don't have an init script for it (but we may add one at some point in the future). But it already exists for tons of other daemons/services.

Quoted 2 lines

In that sense, it does make sense to offer an option to choose between the
logging providers.

No, see above :-)

Quoted 4 lines

However, as I mentioned before, I see this as completely orthogonal to the
S01logging cleanup, because this series is in fact mostly about standardizing the format of the init scripts. So Carlos, if you prefer to keep it as S01logging, that's fine.

On this, I totally agree, it is independent from Carlos work.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com