Skip to content

RFC atmodem/lte atom

Giacinto Cifelli ofono 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 RFC Latest1 patch 13 repliesIn review
  2. v11 of 5 patches 2 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1atmodem/lte: proto and authentication handlingdrivers/atmodem/lte.c+84 -1013 replies

Reviews trailers per patch

The patch has no Reviewed-by or Acked-by.

PatchMartin Baschin
1/1Co-authored-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [RFC PATCH v3 0/1] atmodem/lte atom

I would like to have this new version of the lte atom patch reviewed.

I have integrated all Jonas and Denis comments, except Jonas request to change the cbd in the fuction at_lte_set_default_attach_info, which I don't know how to do neatly in a driver. In all example I see the allocation is done in the core, so that there is no problem for the cleanup. If you could point out an example of structure passed as data in the drivers, I would use the same.

This is only a partial submit, if it is ok I will send the series. The differences in this version related to the v2 are:
- use of size_t for lengths
- naming convention for callback function
- restructuring of the cgdcont string according to Jonas wishes
- revovered memory leak in case of failure of g_at_chat_send in the function at_lte_set_default_attach_info
- removed useless and out-of-patch change in lte_delayed_register

Giacinto Cifelli (1):
atmodem/lte: proto and authentication handling

 drivers/atmodem/lte.c | 94 ++++++++++++++++++++++++++++++++++++++-----
 1 file changed, 84 insertions(+), 10 deletions(-)

--
2.17.1