Skip to content

RFC atmodem/lte: added Gemalto vendor

Giacinto Cifelli ofono 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest1 patch 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1atmodem/lte: Gemalto vendor specific extensiondrivers/atmodem/atutil.c drivers/atmodem/atutil.h drivers/atmodem/lte.c+281 -108 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/1] atmodem/lte: added Gemalto vendor

I would like to submit for review the following patch, for adding the Gemalto vendor. I submit in a single patch also the modifications under discussion in a separate thread, for ease of reading.

The main point I would like to ask is where to put the vendor-specific but shared functions for formating the AT commands, because the same procedures are used for gprs-context.

The point is valid also for other vendors: for example uBlox requires the following format: "CHAP:apn" or "PAP:apn", if there is a context authentication, in the AccessPoint string, on top of the authentication command.

Giacinto Cifelli (1):
atmodem/lte: Gemalto vendor specific extension

 drivers/atmodem/atutil.c | 103 +++++++++++++++++++++++++
 drivers/atmodem/atutil.h |  27 +++++++
 drivers/atmodem/lte.c    | 161 ++++++++++++++++++++++++++++++++++++---
 3 files changed, 281 insertions(+), 10 deletions(-)
Signature · 1 line
2.17.1