Skip to content

PCI: Cleanup pci-keystone driver

Kishon Vijay Abraham I linux-arm-kernel linux-devicetree linux-pci lkml 2 versions – Applied

Status from this message: I have applied the series to pci/keystone, tentatively for v4.20.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest21 patches 1 replyApplied
  2. v119 patches 2 repliesSuperseded

Changes in v2 from the cover letter

*) remove phy_reset in the cleanup PHY handling patch. It will be sent
while adding AM654 support
*) Add a separate patch for using ERR_IRQ_STATUS instead of
ERR_IRQ_STATUS_RAW
*) Split outbound window configuration into two patches. One which
gets the number of outbound windows from DT and the other cleansup outbound window configuration.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/21PCI: keystone: Use quirk to limit MRRS for K2Gdrivers/pci/controller/dwc/pci-keystone.c+3 -00 replies
2/21PCI: keystone: Use quirk to set MRRS for PCI host bridgedrivers/pci/controller/dwc/pci-keystone.c+15 -220 replies
3/21PCI: keystone: Move dw_pcie_setup_rc out of ks_pcie_establish_link()drivers/pci/controller/dwc/pci-keystone.c+2 -30 replies
4/21PCI: keystone: Do not initiate link training multiple timesdrivers/pci/controller/dwc/pci-keystone.c+4 -60 replies
5/21PCI: keystone: Remove unused argument from ks_dw_pcie_host_init()drivers/pci/controller/dwc/pci-keystone-dw.c drivers/pci/controller/dwc/pci-keystone.c drivers/pci/controller/dwc/pci-keystone.h+3 -50 replies
6/21PCI: keystone: Merge pci-keystone-dw.c and pci-keystone.cMAINTAINERS drivers/pci/controller/dwc/Makefile drivers/pci/controller/dwc/pci-keystone-dw.c +2 more+490 -5420 replies
7/21PCI: keystone: Remove redundant platform_set_drvdatadrivers/pci/controller/dwc/pci-keystone.c+0 -20 replies
8/21PCI: keystone: Use uniform function naming conventiondrivers/pci/controller/dwc/pci-keystone.c+111 -1100 replies
9/21dt-bindings: PCI: keystone: Add bindings to get device control moduleDocumentation/devicetree/bindings/pci/pci-keystone.txt+3 -00 replies
10/21PCI: keystone: Use SYSCON APIs to get device ID from control moduledrivers/pci/controller/dwc/pci-keystone.c+32 -130 replies
11/21PCI: keystone: Cleanup PHY handlingdrivers/pci/controller/dwc/pci-keystone.c+106 -160 replies
12/21PCI: keystone: Invoke pm_runtime APIs to enable clockdrivers/pci/controller/dwc/pci-keystone.c+12 -160 replies
13/21PCI: keystone: Cleanup configuration space accessdrivers/pci/controller/dwc/pci-keystone.c+20 -500 replies
14/21PCI: keystone: Get number of outbound windows from DTdrivers/pci/controller/dwc/pci-keystone.c+11 -20 replies
15/21PCI: keystone: Cleanup outbound window configurationdrivers/pci/controller/dwc/pci-keystone.c+17 -150 replies
16/21PCI: keystone: Cleanup set_dbi_mode and get_dbi_modedrivers/pci/controller/dwc/pci-keystone.c+7 -50 replies
17/21PCI: keystone: Cleanup ks_pcie_link_up()drivers/pci/controller/dwc/pci-keystone.c drivers/pci/controller/dwc/pcie-designware.h+7 -80 replies
18/21PCI: keystone: Use ERR_IRQ_STATUS instead of ERR_IRQ_STATUS_RAW to get interrupt statusdrivers/pci/controller/dwc/pci-keystone.c+1 -20 replies
19/21PCI: keystone: Add debug error message for all errorsdrivers/pci/controller/dwc/pci-keystone.c+23 -90 replies
20/21PCI: keystone: Reorder header file in alphabetical orderdrivers/pci/controller/dwc/pci-keystone.c+4 -40 replies
21/21PCI: keystone: Cleanup macros defined in pci-keystone.cdrivers/pci/controller/dwc/pci-keystone.c+16 -250 replies

Reviews trailers per patch

1 of 21 patches has a Reviewed-by or Acked-by.

PatchRob Herring
1/21
2/21
3/21
4/21
5/21
6/21
7/21
8/21
9/21R-b
10/21
11/21
12/21
13/21
14/21
15/21
16/21
17/21
18/21
19/21
20/21
21/21

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/21] PCI: Cleanup pci-keystone driver

The PCIe controller in AM654 uses Synopsys core revision 4.90a and uses the same TI wrapper as used in keystone2 with certain modification. Hence AM654 will use the same pci wrapper driver pci-keystone.c

In preparation for adding AM654 support, cleanup pci-keystone driver here.

Most of the cleanups here are trivial with major modification being merging pci-keystone-dw.c and pci-keystone.c

Cleaning-up irq handling in the RFC series is dropped here as it has few comments to be addressed.

Changes from v1:
*) remove phy_reset in the cleanup PHY handling patch. It will be sent
while adding AM654 support
*) Add a separate patch for using ERR_IRQ_STATUS instead of
ERR_IRQ_STATUS_RAW
*) Split outbound window configuration into two patches. One which
gets the number of outbound windows from DT and the other cleansup outbound window configuration.

Kishon Vijay Abraham I (21):
PCI: keystone: Use quirk to limit MRRS for K2G
PCI: keystone: Use quirk to set MRRS for PCI host bridge
PCI: keystone: Move dw_pcie_setup_rc out of ks_pcie_establish_link()
PCI: keystone: Do not initiate link training multiple times
PCI: keystone: Remove unused argument from ks_dw_pcie_host_init()
PCI: keystone: Merge pci-keystone-dw.c and pci-keystone.c
PCI: keystone: Remove redundant platform_set_drvdata
PCI: keystone: Use uniform function naming convention
dt-bindings: PCI: keystone: Add bindings to get device control module
PCI: keystone: Use syscon APIs to get device id from control module
PCI: keystone: Cleanup PHY handling
PCI: keystone: Invoke pm_runtime APIs to enable clock
PCI: keystone: Cleanup configuration space access
PCI: keystone: Get number of outbound windows from DT
PCI: keystone: Cleanup outbound window configuration
PCI: keystone: Cleanup set_dbi_mode and get_dbi_mode
PCI: keystone: Cleanup ks_pcie_link_up()
PCI: keystone: Use ERR_IRQ_STATUS instead of ERR_IRQ_STATUS_RAW to get
interrupt status
PCI: keystone: Add debug error message for all errors
PCI: keystone: Reorder header file in alphabetical order
PCI: keystone: Cleanup macros defined in pci-keystone.c

 .../devicetree/bindings/pci/pci-keystone.txt  |   3 +
 MAINTAINERS                                   |   2 +-
 drivers/pci/controller/dwc/Makefile           |   2 +-
 drivers/pci/controller/dwc/pci-keystone-dw.c  | 484 -----------
 drivers/pci/controller/dwc/pci-keystone.c     | 788 +++++++++++++++---
 drivers/pci/controller/dwc/pci-keystone.h     |  57 --
 drivers/pci/controller/dwc/pcie-designware.h  |   4 +
 7 files changed, 686 insertions(+), 654 deletions(-)
 delete mode 100644 drivers/pci/controller/dwc/pci-keystone-dw.c
 delete mode 100644 drivers/pci/controller/dwc/pci-keystone.h
Signature · 1 line
2.17.1